Skip to content

Fix sync server version API consistency#81

Closed
Mirochill wants to merge 1 commit into
opendecree:mainfrom
Mirochill:fix-52-server-version-method
Closed

Fix sync server version API consistency#81
Mirochill wants to merge 1 commit into
opendecree:mainfrom
Mirochill:fix-52-server-version-method

Conversation

@Mirochill
Copy link
Copy Markdown

Summary

  • add ConfigClient.get_server_version() to match AsyncConfigClient.get_server_version()
  • keep ConfigClient.server_version as a deprecated property that emits DeprecationWarning
  • update compatibility checks, tests, docs, and the quickstart example to use the explicit method

Related issues

Closes #52

Test plan

  • git diff --check
  • git diff --cached --check
  • make lint passes - not run locally because this workspace policy forbids running third-party project linters
  • make typecheck passes - not run locally because this workspace policy forbids running third-party project type checks
  • make test passes - not run locally because this workspace policy forbids running third-party project tests

Checklist

  • SDK regenerated if proto changed in decree - not applicable, no proto changes
  • Breaking change flagged in title/description if applicable - not applicable, the existing property remains with a deprecation warning
  • Changelog/release note added if applicable - not added; this is a small API consistency fix for an open issue

Add ConfigClient.get_server_version() to match the async client, deprecate the sync server_version property, and update docs, tests, and the quickstart example.

Assisted-by: OpenAI Codex
@github-actions
Copy link
Copy Markdown

Thanks for your first pull request! We appreciate the contribution.

Before review, please make sure tests pass: cd sdk && pytest

@Mirochill
Copy link
Copy Markdown
Author

Closing this draft because #52 has now been resolved by the merged maintainer PR #83. Thanks for the quick fix.

@Mirochill Mirochill closed this May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent server_version API across sync and async

1 participant