Fix sync server version API consistency#81
Closed
Mirochill wants to merge 1 commit into
Closed
Conversation
Add ConfigClient.get_server_version() to match the async client, deprecate the sync server_version property, and update docs, tests, and the quickstart example. Assisted-by: OpenAI Codex
|
Thanks for your first pull request! We appreciate the contribution. Before review, please make sure tests pass: |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigClient.get_server_version()to matchAsyncConfigClient.get_server_version()ConfigClient.server_versionas a deprecated property that emitsDeprecationWarningRelated issues
Closes #52
Test plan
git diff --checkgit diff --cached --checkmake lintpasses - not run locally because this workspace policy forbids running third-party project lintersmake typecheckpasses - not run locally because this workspace policy forbids running third-party project type checksmake testpasses - not run locally because this workspace policy forbids running third-party project testsChecklist
decree- not applicable, no proto changes