fix(errors): add typed exceptions and capture trailing metadata#85
Merged
Conversation
Add TimeoutError (DEADLINE_EXCEEDED), ResourceExhaustedError, CancelledError, and UnimplementedError to the gRPC status code map. DecreeError now captures trailing_metadata from the RpcError and exposes a retry_after timedelta parsed from google.rpc.RetryInfo packed in the grpc-status-details-bin trailer. Closes #54 Co-Authored-By: Claude <noreply@anthropic.com>
zeevdr
added
size: S
…edError Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…leapis-common-protos) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimeoutError,ResourceExhaustedError,CancelledError, andUnimplementedErrorby type instead of inspecting.code.trailing_metadataonDecreeErrorso callers can inspect raw gRPC trailers (e.g.,google.rpc.ErrorInfo).google.rpc.RetryInfofromgrpc-status-details-binand surfaces the result asretry_after: timedelta | None, making rate-limit and deadline back-off trivial for callers.Test plan
trailing_metadatacaptured and accessible on the exceptionretry_aftercorrectly parsed from packedRetryInfo(seconds + nanos precision)retry_afterwhen metadata is absent or contains noRetryInfoerrors.pyat 100% coverageCloses #54