test(schema): add parameterized table test for errToStatus#392
Open
zeevdr wants to merge 1 commit into
Open
Conversation
errToStatus had no direct tests. The table covers the direct ErrNotFound sentinel, a wrapped ErrNotFound (verifying errors.Is semantics), and any other error mapping to Internal — pinning the gRPC code and message routing at the lowest level. Co-Authored-By: Claude <noreply@anthropic.com> Closes #302
zeevdr
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errToStatushad no direct tests — only implicit coverage when service RPCs hit error paths.errors.Issemantics are honoured, not just pointer equality.Test plan
TestErrToStatus/ErrNotFound_maps_to_NotFound— direct sentinel.TestErrToStatus/wrapped_ErrNotFound_maps_to_NotFound— verifieserrors.Isunwrapping.TestErrToStatus/other_error_maps_to_Internal— any non-NotFound error → Internal.go test ./internal/schema/....make lintpasses.Closes #302
🤖 Generated with Claude Code