feat: easy alternative views#507
Conversation
|
Thanks for the pull request, @Kelketek! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
samuelallan72
left a comment
There was a problem hiding this comment.
- I tested this: followed test instructions
- I read through the code
- I checked for accessibility issues
- Includes documentation
|
@farhan Would you be up for reviewing this? |
Changes LGTM, adding some test cases would be great |
54e5a4a to
cbb33ce
Compare
|
@farhan Added a test for this. |
|
@Kelketek |
|
@farhan I don't have merge rights on this repository. Please merge it if it looks good to you. :) |
|
@Kelketek alright, let me give it a test run on monday, as I am on leaves, after that I will share results or merge it. |
Description
This PR makes it easier to test the studio and authoring views from within the workbench. This is already supported, but currently requires you to manually specify the scenario URL. This desire to avoid picking specific views made sense in the context of XBlock's original vision which might not expect there to necessarily be a studio as part of the spec. In practice, the Open edX platform is the only implementation, and is expected to stay that way, so adding some opinionated conveniences helps here.
This also includes a 'notify' function shim for the runtime. Both the LMS and studio have this notify function. We implement it here as logging.
Testing instructions