[BUGFIX] Fix dropped road segments at z4-5#289
Merged
msbarry merged 27 commits intoopenmaptiles:mainfrom Jan 20, 2026
Merged
Conversation
https://github.com/openmaptiles/planetiler-openmaptiles/actions/runs/21154767358 ℹ️ Base Logs 856f58dℹ️ This Branch Logs 5c9b4fc |
msbarry
reviewed
Dec 6, 2025
Co-authored-by: Michael Barry <msbarry@users.noreply.github.com>
Co-authored-by: Michael Barry <msbarry@users.noreply.github.com>
phanecak-maptiler
approved these changes
Dec 30, 2025
Collaborator
phanecak-maptiler
left a comment
There was a problem hiding this comment.
Look OK to me, thank you.
"OK" = I'd like to have something simpler but I do not see how, hence I'm grateful for this.
Collaborator
|
I realized the updated approach will insert unintentional motorway segments into long trunks at z5 like the transcanada highway. Here's an alternate approach that upgrades trunk to motorway class during initial processing only in this case, and only at z5: ZeLonewolf#3 This should be a more surgical change to the highways, and the tests to verify this behavior are a bit more straightforward. Here's the output: |
Do it all during initial feature processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planetiler implementation of openmaptiles/openmaptiles#1767.
Replicated implementation into Java and added test cases to cover this behavior.
Canada z4 behavior validated in Ontario:
Iowa z5 behavior: