fix(ci): add missing kubectl/kind version env vars to local-dev-simulation#414
Draft
squizzi wants to merge 3 commits into
Draft
fix(ci): add missing kubectl/kind version env vars to local-dev-simulation#414squizzi wants to merge 3 commits into
squizzi wants to merge 3 commits into
Conversation
Closed
1 task
…t-local-dev-simulation
The test-local-dev-simulation job referenced ${KUBECTL_VERSION} and
${KIND_VERSION} in curl download URLs without defining them, causing
the variables to expand to empty strings and producing broken URLs
that returned XML error pages instead of binaries.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Kyle Squizzato <kysquizz@redhat.com>
- Increase sandbox pod readiness timeout from 60s to 180s (root cause of 3 cascading failures in CI) - Use _delete_session helper instead of bare DELETE + sleep 2 for proper pod cleanup before starting short-running session - Skip completion check when LLM response was never received to avoid wasting 120s on a guaranteed timeout - Move gateway readiness wait before port-forward attempt in network policy section to avoid connecting to a restarting pod - Increase port-forward log wait from 6s to 15s for CI reliability Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JuanmaBM
force-pushed
the
squizzi/fix-ci-kubectl-download
branch
from
July 23, 2026 11:34
2a95ab8 to
46023a2
Compare
The control plane was sending the K8s ServiceAccount token as Bearer auth to the gateway, which rejected it with "unknown signing key" because it validates against its own JWT keys, not the K8s API server's. Non-OIDC gateways use mTLS for service auth and accept unauthenticated requests, so clearing the SA token path avoids the spurious validation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jsell-rh
approved these changes
Jul 24, 2026
jsell-rh
left a comment
jsell-rh
left a comment
Collaborator
There was a problem hiding this comment.
🤖 Amber Review
The CI fix is correct and targeted. The three companion improvements in gateway-e2e-test.sh are all clearly better than what they replace.
What I verified:
KUBECTL_VERSION: v1.31.4/KIND_VERSION: v0.31.0matchvteam-catalog-lab-e2e.yml— consistent.- Pod-ready wait extended from 60 s (30 × 2 s) to 180 s (90 × 2 s) with a comment explaining why (
Kind CI is slow) — correct call. - Short-session completion check now gated on
SHORT_LLM_FOUND > 0— avoids a spuriousfailwhen LLM never responds. _delete_sessioninstead of rawapi DELETE + sleep 2— uses the canonical helper, consistent with the rest of the script.OPENSHELL_GATEWAY_SA_TOKEN_PATH=""env var cleared before gateway port-forward is established — sequence makes the comment trustworthy.
Minor (no action needed): This is marked Draft with 3 commits — squash before marking ready if not already planned.
No blockers.
— Amber
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
test-local-dev-simulationjob intest-local-dev.ymlwas failing becauseKUBECTL_VERSIONandKIND_VERSIONenvironment variables were never defined. The curl download URLs expanded to broken paths (e.g./release//bin/linux/amd64/kubectl), causing GCS to return an XML error page that was saved as the kubectl binary.This adds the missing
env:block withKUBECTL_VERSION: v1.31.4andKIND_VERSION: v0.31.0, matching the values used invteam-catalog-lab-e2e.yml.Test plan
test-local-dev-simulationjob without the kubectl syntax errorkubectl version --clientandkind versionsucceed in the workflow logs