Skip to content

[release-4.21] OCPBUGS-85139: Support disk by-path symlinks in deployment ISO#710

Open
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.21from
openshift-cherrypick-robot:cherry-pick-641-to-release-4.21
Open

[release-4.21] OCPBUGS-85139: Support disk by-path symlinks in deployment ISO#710
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.21from
openshift-cherrypick-robot:cherry-pick-641-to-release-4.21

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented May 6, 2026

This is an automated cherry-pick of #641

/assign danielerez

@danielerez
fix: Support disk by-path symlinks in deployment ISO
bb23478 
Fixes the deployment ISO failing to clone the appliance disk image when
using /dev/disk/by-path/* paths as the target device. The virt-resize
command was failing with 'No such file or directory' because symlinks
were not being properly resolved.

Changes:
- Wait for udev to settle before accessing disk paths
- Wait up to 60 seconds for the target device to become available
- Resolve symlinks to their actual device paths before passing to virt-resize
- Add proper error handling when target device is not found
- Add --pull=never to podman run to prevent TTY prompt errors
- Tag loaded image to configured name to fix 'image not found' errors

Fixes: openshift#368
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 6, 2026
Merged
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 6, 2026

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: ISSUE-368

Details

In response to this:

This is an automated cherry-pick of #641

/assign danielerez

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from andfasano and bfournie May 6, 2026 17:40
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign danielerez for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danielerez danielerez changed the title [release-4.21] ISSUE-368: Support disk by-path symlinks in deployment ISO [release-4.21] OCPBUGS-85139: Support disk by-path symlinks in deployment ISO May 6, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 6, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 6, 2026

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-85139, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-85139 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #641

/assign danielerez

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danielerez
Copy link
Copy Markdown
Contributor

danielerez commented May 6, 2026

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 6, 2026

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4-iso-no-registry bb23478 link false /test e2e-agent-compact-ipv4-iso-no-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andfasano andfasano Awaiting requested review from andfasano

@bfournie bfournie Awaiting requested review from bfournie

Assignees

@danielerez danielerez

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-cherrypick-robot @openshift-ci-robot @danielerez