[release-4.21] OCPBUGS-99453: Respect proxy configuration on gwapi provisioning by openshift-cherrypick-robot · Pull Request #1518 · openshift/cluster-ingress-operator

openshift-cherrypick-robot · 2026-07-22T14:43:03Z

This is an automated cherry-pick of #1383

/assign rikatz

This PR adds support for global proxy configuration on Gateway API provisioning. It mutates the Istio resource creation to pass the *_PROXY environment variables when deploying Istio controller, and this is passed down to Gateway instances created by users. This configuration allows envoy proxies that rely on downloading WASMPlugins, on an air-gapped environment that enforces the usage of a network proxy, to download the artifacts using the network proxy.

openshift-merge-bot · 2026-07-22T14:43:05Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

coderabbitai · 2026-07-22T14:43:14Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c5615c56-0d9c-4292-a813-daeac478ec3b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci-robot · 2026-07-22T14:44:14Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-77457 has been cloned as Jira Issue OCPBUGS-99453. Will retitle bug to link to clone.
/retitle [release-4.21] OCPBUGS-99453: Respect proxy configuration on gwapi provisioning

Details

In response to this:

This is an automated cherry-pick of #1383

/assign rikatz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-07-22T14:44:36Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-99453, which is invalid:

expected dependent Jira Issue OCPBUGS-77457 to target a version in 4.22.0, but it targets "4.22" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1383

/assign rikatz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rikatz · 2026-07-22T16:38:46Z

/jira refresh
/lgtm
/approve

openshift-ci-robot · 2026-07-22T16:38:54Z

@rikatz: This pull request references Jira Issue OCPBUGS-99453, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-77457 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-77457 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (iamin@redhat.com), skipping review request.

Details

In response to this:

/jira refresh
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-bot · 2026-07-22T16:39:00Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-operator
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-upgrade
/test e2e-aws-pre-release-ossm
/test e2e-azure-operator
/test e2e-gcp-operator
/test e2e-hypershift
/test e2e-vsphere-static-metallb-operator-gwapi

openshift-ci · 2026-07-22T16:39:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rikatz · 2026-07-22T17:05:25Z

/retest-required

rikatz · 2026-07-22T20:58:20Z

/retest-required

rikatz · 2026-07-28T11:50:04Z

/retest=reqiored

rikatz · 2026-07-28T13:43:11Z

/retest-required

rikatz · 2026-07-29T00:00:17Z

/retest

Miciah · 2026-07-29T14:44:50Z

/assign

rikatz · 2026-07-30T21:19:58Z

/retest-required

rikatz · 2026-07-31T17:26:43Z

/retest-required

redhat-chai-bot · 2026-07-31T20:33:29Z

Backport Risk Assessment — PR #1518 → `release-4.21`

Cherry-pick of #1383 (OCPBUGS-77457 → OCPBUGS-99453)

Overall: Low risk

Risk mitigants

4+ months of soak time — the parent fix landed in nightly 4.22.0-0.nightly-2026-03-23-022245 (March 2026) and shipped in RHEA-2026:0449. The code path is well exercised in 4.22.
No new RBAC required — proxies is already in the operator's ClusterRole on release-4.21 (00-cluster-role.yaml L96-110). This eliminates the HyperShift manifest-ordering concern that would apply if new RBAC had been introduced.
Three-layer graceful degradation — Proxy CR not found → no-op; empty fields → no metadata injected; nil guards at every call site. Clusters without a proxy config are completely unaffected.
Small, additive diff — +169/−23, confined to the GatewayClass controller. Both the OLM and Sail Library installation paths are updated symmetrically.
Clean automated cherry-pick — no merge conflicts, no manual adaptation.

Items to watch

CI — 15/19 checks pass (unit, verify, e2e-aws-operator, e2e-hypershift, upgrade, etc.). Three failures remain: e2e-aws-pre-release-ossm, e2e-vsphere-static-metallb-operator-gwapi, and hypershift-e2e-aks. These should be confirmed as unrelated flakes before merge.
New watch source — the controller now watches configv1.Proxy (filtered to the cluster object). This adds one more informer to the GatewayClass controller. Low-risk since the Proxy CR is a singleton that rarely changes, but it does mean proxy changes will trigger a reconcile of every GatewayClass.

Miciah · 2026-07-31T20:35:01Z

/label backport-risk-assessed

melvinjoseph86 · 2026-08-01T10:20:28Z

launch a cluster using this PR

➜  oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.21.0-0-2026-08-01-064108-test-ci-ln-qv3didb-latest   True        False         164m    Cluster version is 4.21.0-0-2026-08-01-064108-test-ci-ln-qv3didb-latest

➜  oc get gatewayclass
NAME                CONTROLLER                           ACCEPTED   AGE
openshift-default   openshift.io/gateway-controller/v1   True       24s
➜  oc -n openshift-ingress get gateway
NAME      CLASS               ADDRESS   PROGRAMMED   AGE
gateway   openshift-default             False        9s

➜  oc -n openshift-ingress get deployment gateway-openshift-default -oyaml | grep PROXY -A1
        - name: PROXY_CONFIG
          value: |
➜  oc edit proxy cluster
proxy.config.openshift.io/cluster edited
➜  oc get proxy cluster -o yaml
apiVersion: config.openshift.io/v1
kind: Proxy
metadata:
  creationTimestamp: "2026-08-01T06:59:04Z"
  generation: 2
  name: cluster
  resourceVersion: "71846"
  uid: b04a878f-126f-461e-9b30-032f76ddf6af
spec:
  httpProxy: http://some.proxy.tld:8080
  httpsProxy: http://another.proxy.tld:8080
  trustedCA:
    name: ""
status:
  httpProxy: http://some.proxy.tld:8080
  httpsProxy: http://another.proxy.tld:8080
  noProxy: .cluster.local,.svc,.us-west-2.compute.internal,10.0.0.0/16,10.128.0.0/14,127.0.0.1,169.254.169.254,172.30.0.0/16,api-int.ci-ln-qv3didb-76ef8.aws-4.ci.openshift.org,localhost

➜  oc -n openshift-ingress get deployment gateway-openshift-default -oyaml | grep PROXY -A1
        - name: PROXY_CONFIG
          value: |
            {"discoveryAddress":"istiod-openshift-gateway.openshift-ingress.svc:15012","proxyMetadata":{"HTTPS_PROXY":"http://another.proxy.tld:8080","HTTP_PROXY":"http://some.proxy.tld:8080","NO_PROXY":".cluster.local,.svc,.us-west-2.compute.internal,10.0.0.0/16,10.128.0.0/14,127.0.0.1,169.254.169.254,172.30.0.0/16,api-int.ci-ln-qv3didb-76ef8.aws-4.ci.openshift.org,localhost","http_proxy":"http://some.proxy.tld:8080","https_proxy":"http://another.proxy.tld:8080","no_proxy":".cluster.local,.svc,.us-west-2.compute.internal,10.0.0.0/16,10.128.0.0/14,127.0.0.1,169.254.169.254,172.30.0.0/16,api-int.ci-ln-qv3didb-76ef8.aws-4.ci.openshift.org,localhost"},"proxyHeaders":{"server":{"disabled":true},"envoyDebugHeaders":{"disabled":true},"metadataExchangeHeaders":{"mode":"IN_MESH"}}}
        - name: ISTIO_META_POD_PORTS
--
        - name: HTTPS_PROXY
          value: http://another.proxy.tld:8080
        - name: HTTP_PROXY
          value: http://some.proxy.tld:8080
        - name: NO_PROXY
          value: .cluster.local,.svc,.us-west-2.compute.internal,10.0.0.0/16,10.128.0.0/14,127.0.0.1,169.254.169.254,172.30.0.0/16,api-int.ci-ln-qv3didb-76ef8.aws-4.ci.openshift.org,localhost

➜   oc -n openshift-ingress get pod    
NAME                                         READY   STATUS    RESTARTS   AGE
gateway-openshift-default-6848cb97b7-sn6z2   1/1     Running   0          91s
istiod-openshift-gateway-7b7995d5cd-knvs6    1/1     Running   0          4m19s
router-default-754768d7bb-7xkt2              1/1     Running   0          93s
router-default-754768d7bb-xw6n8              1/1     Running   0          93s

➜  oc  get pods -n openshift-ingress gateway-openshift-default-6848cb97b7-sn6z2 -o jsonpath='{range .spec.containers[*].env[*]}{.name}{"="}{.value}{"\n"}{end}' |grep PROXY
PROXY_CONFIG={"discoveryAddress":"istiod-openshift-gateway.openshift-ingress.svc:15012","proxyMetadata":{"HTTPS_PROXY":"http://another.proxy.tld:8080","HTTP_PROXY":"http://some.proxy.tld:8080","NO_PROXY":".cluster.local,.svc,.us-west-2.compute.internal,10.0.0.0/16,10.128.0.0/14,127.0.0.1,169.254.169.254,172.30.0.0/16,api-int.ci-ln-qv3didb-76ef8.aws-4.ci.openshift.org,localhost","http_proxy":"http://some.proxy.tld:8080","https_proxy":"http://another.proxy.tld:8080","no_proxy":".cluster.local,.svc,.us-west-2.compute.internal,10.0.0.0/16,10.128.0.0/14,127.0.0.1,169.254.169.254,172.30.0.0/16,api-int.ci-ln-qv3didb-76ef8.aws-4.ci.openshift.org,localhost"},"proxyHeaders":{"server":{"disabled":true},"envoyDebugHeaders":{"disabled":true},"metadataExchangeHeaders":{"mode":"IN_MESH"}}}
HTTPS_PROXY=http://another.proxy.tld:8080
HTTP_PROXY=http://some.proxy.tld:8080
NO_PROXY=.cluster.local,.svc,.us-west-2.compute.internal,10.0.0.0/16,10.128.0.0/14,127.0.0.1,169.254.169.254,172.30.0.0/16,api-int.ci-ln-qv3didb-76ef8.aws-4.ci.openshift.org,localhost

/verified by @mjoseph

openshift-ci-robot · 2026-08-01T10:20:38Z

@melvinjoseph86: This PR has been marked as verified by @mjoseph.

Details

In response to this:

launch a cluster using this PR

➜  oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.21.0-0-2026-08-01-064108-test-ci-ln-qv3didb-latest   True        False         164m    Cluster version is 4.21.0-0-2026-08-01-064108-test-ci-ln-qv3didb-latest

➜  oc get gatewayclass
NAME                CONTROLLER                           ACCEPTED   AGE
openshift-default   openshift.io/gateway-controller/v1   True       24s
➜  oc -n openshift-ingress get gateway
NAME      CLASS               ADDRESS   PROGRAMMED   AGE
gateway   openshift-default             False        9s

➜  oc -n openshift-ingress get deployment gateway-openshift-default -oyaml | grep PROXY -A1
       - name: PROXY_CONFIG
         value: |
➜  oc edit proxy cluster
proxy.config.openshift.io/cluster edited
➜  oc get proxy cluster -o yaml
apiVersion: config.openshift.io/v1
kind: Proxy
metadata:
 creationTimestamp: "2026-08-01T06:59:04Z"
 generation: 2
 name: cluster
 resourceVersion: "71846"
 uid: b04a878f-126f-461e-9b30-032f76ddf6af
spec:
 httpProxy: http://some.proxy.tld:8080
 httpsProxy: http://another.proxy.tld:8080
 trustedCA:
   name: ""
status:
 httpProxy: http://some.proxy.tld:8080
 httpsProxy: http://another.proxy.tld:8080
 noProxy: .cluster.local,.svc,.us-west-2.compute.internal,10.0.0.0/16,10.128.0.0/14,127.0.0.1,169.254.169.254,172.30.0.0/16,api-int.ci-ln-qv3didb-76ef8.aws-4.ci.openshift.org,localhost

➜  oc -n openshift-ingress get deployment gateway-openshift-default -oyaml | grep PROXY -A1
       - name: PROXY_CONFIG
         value: |
           {"discoveryAddress":"istiod-openshift-gateway.openshift-ingress.svc:15012","proxyMetadata":{"HTTPS_PROXY":"http://another.proxy.tld:8080","HTTP_PROXY":"http://some.proxy.tld:8080","NO_PROXY":".cluster.local,.svc,.us-west-2.compute.internal,10.0.0.0/16,10.128.0.0/14,127.0.0.1,169.254.169.254,172.30.0.0/16,api-int.ci-ln-qv3didb-76ef8.aws-4.ci.openshift.org,localhost","http_proxy":"http://some.proxy.tld:8080","https_proxy":"http://another.proxy.tld:8080","no_proxy":".cluster.local,.svc,.us-west-2.compute.internal,10.0.0.0/16,10.128.0.0/14,127.0.0.1,169.254.169.254,172.30.0.0/16,api-int.ci-ln-qv3didb-76ef8.aws-4.ci.openshift.org,localhost"},"proxyHeaders":{"server":{"disabled":true},"envoyDebugHeaders":{"disabled":true},"metadataExchangeHeaders":{"mode":"IN_MESH"}}}
       - name: ISTIO_META_POD_PORTS
--
       - name: HTTPS_PROXY
         value: http://another.proxy.tld:8080
       - name: HTTP_PROXY
         value: http://some.proxy.tld:8080
       - name: NO_PROXY
         value: .cluster.local,.svc,.us-west-2.compute.internal,10.0.0.0/16,10.128.0.0/14,127.0.0.1,169.254.169.254,172.30.0.0/16,api-int.ci-ln-qv3didb-76ef8.aws-4.ci.openshift.org,localhost

➜   oc -n openshift-ingress get pod    
NAME                                         READY   STATUS    RESTARTS   AGE
gateway-openshift-default-6848cb97b7-sn6z2   1/1     Running   0          91s
istiod-openshift-gateway-7b7995d5cd-knvs6    1/1     Running   0          4m19s
router-default-754768d7bb-7xkt2              1/1     Running   0          93s
router-default-754768d7bb-xw6n8              1/1     Running   0          93s

➜  oc  get pods -n openshift-ingress gateway-openshift-default-6848cb97b7-sn6z2 -o jsonpath='{range .spec.containers[*].env[*]}{.name}{"="}{.value}{"\n"}{end}' |grep PROXY
PROXY_CONFIG={"discoveryAddress":"istiod-openshift-gateway.openshift-ingress.svc:15012","proxyMetadata":{"HTTPS_PROXY":"http://another.proxy.tld:8080","HTTP_PROXY":"http://some.proxy.tld:8080","NO_PROXY":".cluster.local,.svc,.us-west-2.compute.internal,10.0.0.0/16,10.128.0.0/14,127.0.0.1,169.254.169.254,172.30.0.0/16,api-int.ci-ln-qv3didb-76ef8.aws-4.ci.openshift.org,localhost","http_proxy":"http://some.proxy.tld:8080","https_proxy":"http://another.proxy.tld:8080","no_proxy":".cluster.local,.svc,.us-west-2.compute.internal,10.0.0.0/16,10.128.0.0/14,127.0.0.1,169.254.169.254,172.30.0.0/16,api-int.ci-ln-qv3didb-76ef8.aws-4.ci.openshift.org,localhost"},"proxyHeaders":{"server":{"disabled":true},"envoyDebugHeaders":{"disabled":true},"metadataExchangeHeaders":{"mode":"IN_MESH"}}}
HTTPS_PROXY=http://another.proxy.tld:8080
HTTP_PROXY=http://some.proxy.tld:8080
NO_PROXY=.cluster.local,.svc,.us-west-2.compute.internal,10.0.0.0/16,10.128.0.0/14,127.0.0.1,169.254.169.254,172.30.0.0/16,api-int.ci-ln-qv3didb-76ef8.aws-4.ci.openshift.org,localhost

/verified by @mjoseph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

melvinjoseph86 · 2026-08-01T10:22:10Z

/retest-required

melvinjoseph86 · 2026-08-01T10:22:54Z

/test e2e-vsphere-static-metallb-operator-gwapi

openshift-merge-bot · 2026-08-01T14:26:30Z

/retest-required

Remaining retests: 0 against base HEAD 1723491 and 2 for PR HEAD a59b6c2 in total

redhat-chai-bot · 2026-08-01T17:02:35Z

Hi @openshift-ci[bot] -- I can only respond automatically to comments from verified Red Hat associates.

Your GitHub account could not be confirmed. If you are a Red Hat employee and believe this is an error, please ask for help in the #chai-users Slack channel.

melvinjoseph86 · 2026-08-01T17:11:05Z

/retest-required

melvinjoseph86 · 2026-08-01T18:20:04Z

/test okd-scos-images

openshift-ci · 2026-08-01T18:29:04Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-pre-release-ossm	`a59b6c2`	link	false	`/test e2e-aws-pre-release-ossm`
ci/prow/okd-scos-images	`a59b6c2`	link	true	`/test okd-scos-images`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-cherrypick-robot assigned rikatz Jul 22, 2026

openshift-cherrypick-robot mentioned this pull request Jul 22, 2026

OCPBUGS-77457: Respect proxy configuration on gwapi provisioning #1383

Merged

openshift-ci Bot changed the title ~~[release-4.21] OCPBUGS-77457: Respect proxy configuration on gwapi provisioning~~ [release-4.21] OCPBUGS-99453: Respect proxy configuration on gwapi provisioning Jul 22, 2026

openshift-ci Bot requested review from frobware and grzpiotrowski July 22, 2026 14:48

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 22, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2026

openshift-ci Bot assigned Miciah Jul 29, 2026

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 31, 2026

openshift-ci Bot assigned melvinjoseph86 and rhamini3 Jul 31, 2026

redhat-chai-bot mentioned this pull request Aug 1, 2026

[release-4.20] OCPBUGS-99476: Respect proxy configuration on gwapi provisioning #1519

Open

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 1, 2026

Uh oh!

Conversation

openshift-cherrypick-robot commented Jul 22, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 22, 2026

Uh oh!

coderabbitai Bot commented Jul 22, 2026

Review skipped

Uh oh!

openshift-ci-robot commented Jul 22, 2026

Uh oh!

openshift-ci-robot commented Jul 22, 2026

Uh oh!

rikatz commented Jul 22, 2026

Uh oh!

openshift-ci-robot commented Jul 22, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 22, 2026

Uh oh!

openshift-ci Bot commented Jul 22, 2026

Uh oh!

rikatz commented Jul 22, 2026

Uh oh!

rikatz commented Jul 22, 2026

Uh oh!

rikatz commented Jul 28, 2026

Uh oh!

rikatz commented Jul 28, 2026

Uh oh!

rikatz commented Jul 29, 2026

Uh oh!

Miciah commented Jul 29, 2026

Uh oh!

rikatz commented Jul 30, 2026

Uh oh!

rikatz commented Jul 31, 2026

Uh oh!

redhat-chai-bot commented Jul 31, 2026

Backport Risk Assessment — PR #1518 → release-4.21

Risk mitigants

Items to watch

Uh oh!

Miciah commented Jul 31, 2026

Uh oh!

melvinjoseph86 commented Aug 1, 2026

Uh oh!

openshift-ci-robot commented Aug 1, 2026

Uh oh!

melvinjoseph86 commented Aug 1, 2026

Uh oh!

melvinjoseph86 commented Aug 1, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 1, 2026

Uh oh!

redhat-chai-bot commented Aug 1, 2026

Uh oh!

melvinjoseph86 commented Aug 1, 2026

Uh oh!

melvinjoseph86 commented Aug 1, 2026

Uh oh!

openshift-ci Bot commented Aug 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Backport Risk Assessment — PR #1518 → `release-4.21`