NE-2491: Delete the CRL controller

[Miciah]

The CRL controller was originally added to download Certificate Revocation Lists, but that functionality was moved to the router in OpenShift 4.14. The controller was then updated to only delete any existing configmap it had created. It has been unnecessary since OpenShift 4.15 and should be removed.

Follow-up to #939.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@Miciah: This pull request references NE-2491 which is a valid jira issue.

Details

In response to this:

The CRL controller was originally added to download Certificate Revocation Lists, but that functionality was moved to the router in OpenShift 4.14. The controller was then updated to only delete any existing configmap it had created. It has been unnecessary since OpenShift 4.15 and should be removed.

Follow-up to #939.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bentito for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b007c194-e6ba-4932-bd3f-52f0119a0a09

📥 Commits

Reviewing files that changed from the base of the PR and between 5f66129 and baf9f26.

📒 Files selected for processing (4)

• pkg/operator/controller/crl/controller.go
• pkg/operator/controller/crl/crl_configmap.go
• pkg/operator/controller/names.go
• pkg/operator/operator.go

💤 Files with no reviewable changes (4)

• pkg/operator/controller/names.go
• pkg/operator/controller/crl/crl_configmap.go
• pkg/operator/controller/crl/controller.go
• pkg/operator/operator.go

---

📝 Walkthrough

Walkthrough

The CRL controller and its reconciliation implementation were deleted. The operator no longer imports or initializes the CRL controller. The public CRLConfigMapName helper was removed. No replacement CRL controller or naming logic was added.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely states that the CRL controller is being deleted.
Description check	✅ Passed	The description explains why the CRL controller is unnecessary and directly relates to the removal changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The patch changes no *_test.go files and adds or modifies no Ginkgo test declarations; it only removes controller and production code.
Test Structure And Quality	✅ Passed	The commit changes only four non-test Go files, adds no Ginkgo calls, and modifies no test paths; these test-quality requirements are not applicable.
Microshift Test Compatibility	✅ Passed	The commit only deletes CRL controller code and removes registrations; it adds no Ginkgo e2e tests or new MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit adds no Ginkgo e2e tests or test files; it only deletes the CRL controller and updates operator wiring, so SNO compatibility checks do not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR only deletes the CRL controller, helper, and registration; the diff adds no deployment manifests, replicas, affinity, topology spread, node selectors, tolerations, or PDB constraints.
Ote Binary Stdout Contract	✅ Passed	The PR does not modify tests-extension. OTE main sends its diagnostic to os.Stderr, and no process-level fmt/log/klog stdout writes exist; test output uses GinkgoWriter inside It.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit adds no Ginkgo tests or test files; it only deletes the CRL controller and removes its registration, so IPv6 or external-connectivity test checks do not apply.
No-Weak-Crypto	✅ Passed	The PR only deletes CRL reconciliation code and registration; the parent-to-HEAD diff has no MD5, SHA1, DES, RC4, Blowfish, ECB, or custom crypto usage.
Container-Privileges	✅ Passed	The PR has 0 additions, changes no container or Kubernetes manifests, and introduces no forbidden privilege setting.
No-Sensitive-Data-In-Logs	✅ Passed	The patch adds zero source lines. It only deletes the CRL controller and removes its registration and name helper, so it introduces no sensitive-data logging.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

@Miciah: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.