Skip to content

OSDOCS-19684-FINAL#111652

Open
jseseCCS wants to merge 1 commit into
openshift:enterprise-4.22from
jseseCCS:OSDOCS-19684-FIX
Open

OSDOCS-19684-FINAL#111652
jseseCCS wants to merge 1 commit into
openshift:enterprise-4.22from
jseseCCS:OSDOCS-19684-FIX

Conversation

@jseseCCS
Copy link
Copy Markdown
Contributor

@jseseCCS jseseCCS commented May 14, 2026 •
edited
Loading

[enterprise-4.22] Remove MS attribute from reused networking module

Version(s): 4.22

Issue: OSDOCS-19684

Link to docs preview:

QE review: N/A (release note)

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 14, 2026

Hi @jseseCCS. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jseseCCS jseseCCS force-pushed the OSDOCS-19684-FIX branch from 8c42f1b to 4d7bc1e Compare May 14, 2026 13:54
@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2026
@jseseCCS jseseCCS force-pushed the OSDOCS-19684-FIX branch from f4fbe67 to 44bde2b Compare May 14, 2026 14:25
@webbnh
Copy link
Copy Markdown

webbnh commented May 14, 2026

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2026
webbnh
webbnh reviewed May 14, 2026
View reviewed changes
Copy link
Copy Markdown

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said in #111526 (review), looks good except for one word. 🙂

Comment thread modules/rn-ocp-release-notes-new-features.adoc Outdated
+
You can now configure basic authentication credentials when you create a `ProjectHelmChartRepository` custom resource from the OpenShift web console. Previously, connecting to Helm chart repositories that require username and password authentication required manually editing YAML. With this enhancement, you can provide credentials directly in the form UI.
+
When basic authentication is configured, the web console enforces HTTPS for the repository URL to ensure that credentials are transmitted securely.
Copy link
Copy Markdown

@webbnh webbnh May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this one request: change "enforces" to "requires"?

@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented May 14, 2026 •
edited
Loading

🤖 Fri May 15 16:14:31 - Prow CI generated the docs preview:

https://111652--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-22-release-notes.html

@jseseCCS jseseCCS force-pushed the OSDOCS-19684-FIX branch from 44bde2b to 3504386 Compare May 15, 2026 15:48
@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 15, 2026
webbnh
webbnh approved these changes May 15, 2026
View reviewed changes
Copy link
Copy Markdown

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2026
@jseseCCS jseseCCS force-pushed the OSDOCS-19684-FIX branch from a2ded56 to 47b99bb Compare May 15, 2026 15:59
@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 15, 2026
@jseseCCS jseseCCS force-pushed the OSDOCS-19684-FIX branch from 47b99bb to af43b3b Compare May 15, 2026 16:05
@openshift-ci openshift-ci Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2026
webbnh
webbnh approved these changes May 15, 2026
View reviewed changes
Copy link
Copy Markdown

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2026
@jseseCCS
Copy link
Copy Markdown
Contributor Author

jseseCCS commented May 15, 2026

/label merge-review-needed

@openshift-ci openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 15, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 15, 2026

@jseseCCS: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR ok-to-merge and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 15, 2026
@mburke5678
Copy link
Copy Markdown
Contributor

mburke5678 commented May 15, 2026

@jseseCCS OK to merge after you fix the conflict.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 15, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@webbnh webbnh webbnh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@webbnh webbnh

Labels

lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-merge ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jseseCCS @webbnh @ocpdocs-previewbot @mburke5678