Skip to content

DNM Set gc-metrics=true for control-plane chain workloads #79346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohit-sheth wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DNM Set gc-metrics=true for control-plane chain workloads #79346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...or/step-registry/openshift-qe/cluster-density-v2/openshift-qe-cluster-density-v2-ref.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ ref:
documentation: |-
Default is true, which means clean up the pod/resource that kube-burner ocp created, you can set it to false to keep the resouce
- name: GC_METRICS
default: "false"
default: "true"
documentation: |-
Default is false, which means skip collecting metrics, you can set it to true to collect metrics.
Default is true, which means collect metrics, you can set it to false to skip that.
- name: PROFILE_TYPE
default: "both"
documentation: |-
Expand Down
2 changes: 1 addition & 1 deletion ci-operator/step-registry/openshift-qe/crd-scale/openshift-qe-crd-scale-commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,6 @@ pushd e2e-benchmarking/workloads/kube-burner-ocp-wrapper
export WORKLOAD=crd-scale

export ES_SERVER="https://$ES_USERNAME:$ES_PASSWORD@$ES_HOST"
export EXTRA_FLAGS="${KB_FLAGS} ${CRD_SCALE_EXTRA_FLAGS} --gc-metrics=false --profile-type=${PROFILE_TYPE} --iterations=${ITERATIONS}"
export EXTRA_FLAGS="${KB_FLAGS} ${CRD_SCALE_EXTRA_FLAGS} --gc-metrics=true --profile-type=${PROFILE_TYPE} --iterations=${ITERATIONS}"

./run.sh
4 changes: 2 additions & 2 deletions ...erator/step-registry/openshift-qe/node-density-cni/openshift-qe-node-density-cni-ref.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ ref:
documentation: |-
Default is true, which means clean up the pod/resource that kube-burner ocp created, you can set it to false to keep the resouce
- name: GC_METRICS
default: "false"
default: "true"
documentation: |-
Default is false, which means skip collecting metrics, you can set it to true to collect metrics.
Default is true, which means collect metrics, you can set it to false to skip that.
- name: PROFILE_TYPE
default: "both"
documentation: |-
Expand Down
2 changes: 1 addition & 1 deletion ci-operator/step-registry/openshift-qe/node-density/openshift-qe-node-density-commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ TAG_OPTION="--branch $(if [ "$E2E_VERSION" == "default" ]; then echo "$LATEST_TA
git clone $REPO_URL $TAG_OPTION --depth 1
pushd e2e-benchmarking/workloads/kube-burner-ocp-wrapper
export WORKLOAD=node-density
EXTRA_FLAGS="${ND_EXTRA_FLAGS} ${KB_FLAGS} --gc-metrics=false --pods-per-node=$PODS_PER_NODE --pod-ready-threshold=$POD_READY_THRESHOLD --profile-type=${PROFILE_TYPE} --pprof=${PPROF}"
EXTRA_FLAGS="${ND_EXTRA_FLAGS} ${KB_FLAGS} --gc-metrics=true --pods-per-node=$PODS_PER_NODE --pod-ready-threshold=$POD_READY_THRESHOLD --profile-type=${PROFILE_TYPE} --pprof=${PPROF}"

export ES_SERVER="https://$ES_USERNAME:$ES_PASSWORD@$ES_HOST"

Expand Down
2 changes: 1 addition & 1 deletion ...tor/step-registry/openshift-qe/udn-density-pods/openshift-qe-udn-density-pods-commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ fi


export WORKLOAD=udn-density-pods
EXTRA_FLAGS+="${KB_FLAGS} --local-indexing --layer3=${ENABLE_LAYER_3} --gc-metrics=false --pod-ready-threshold=$POD_READY_THRESHOLD --profile-type=${PROFILE_TYPE} --pprof=${PPROF}"
EXTRA_FLAGS+="${KB_FLAGS} --local-indexing --layer3=${ENABLE_LAYER_3} --gc-metrics=true --pod-ready-threshold=$POD_READY_THRESHOLD --profile-type=${PROFILE_TYPE} --pprof=${PPROF}"

export ES_SERVER="https://$ES_USERNAME:$ES_PASSWORD@$ES_HOST"

Expand Down