NO-JIRA: fix: make update fails

[eggfoobar]

make update is checking for a file that does not exist in the current directory it was moved to the crd sub directory

#78980 moved the location of this file, causing make update to fail

This PR fixes the failing make update command in the OpenShift release CI infrastructure repository. The make update target relies on several downstream targets, including update_crt_crd, which in turn depends on the crds variable and related download steps.

When PR #78980 restructured the cluster folders and moved testimagestreamtagimport.yaml from clusters/build-clusters/common/ to the new clusters/build-clusters/common/crd/ subdirectory, the Makefile was not updated accordingly. This caused make update to fail because it was checking for the CRD file in the old, non-existent location.

This PR aligns the Makefile with the current repository structure by updating two things:

1. The download_dp_crd target now downloads testimagestreamtagimport.yaml to the correct location at clusters/build-clusters/common/crd/
2. The crds variable list is updated to reference the file at its new path

These changes restore functionality to the make update workflow, which is essential for maintaining the OpenShift CI infrastructure configuration.

[openshift-ci-robot]

@eggfoobar: This pull request explicitly references no jira issue.

Details

In response to this:

make update is checking for a file that does not exist in the current directory it was moved to the crd sub directory

#78980 moved the location of this file, causing make update to fail

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@eggfoobar: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 81e3e1cf-c71e-4885-9201-96892868e41b

📥 Commits

Reviewing files that changed from the base of the PR and between ab6ae8f and 486e5fb.

📒 Files selected for processing (1)

• Makefile

---

Walkthrough

The Makefile is updated to place the downloaded testimagestreamtagimport.yaml file into a dedicated clusters/build-clusters/common/crd/ subdirectory instead of the parent clusters/build-clusters/common/ directory. The crds variable is synchronized to reference the new file location, ensuring downstream update_dp_crd and update_crt_crd targets use the correct path.

Changes

CRD file path reorganization

Layer / File(s)	Summary
CRD output path and variable update Makefile	download_dp_crd target and crds variable are updated together to move testimagestreamtagimport.yaml into a dedicated crd/ subdirectory and synchronize the downstream dependency paths.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'NO-JIRA: fix: make update fails' accurately describes the main change—fixing a failing make update command caused by a file path change in the Makefile.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only modifies Makefile paths. No Ginkgo test files or test declarations are present or modified. Check for stable test names is not applicable.
Test Structure And Quality	✅ Passed	This PR only modifies Makefile configuration to fix a file path. It contains no Ginkgo test code, making the test structure and quality check inapplicable to this pull request.
Microshift Test Compatibility	✅ Passed	This PR only updates Makefile paths (where testimagestreamtagimport.yaml is downloaded). No new Ginkgo e2e tests are added, so the MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR does not add or modify any Ginkgo e2e tests. It only updates Makefile targets and paths for downloading/managing CRD files. The SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only updates Makefile build paths for a CRD file reference. Custom check applies to deployment manifests, operator code, or controllers—none modified here. CRD contains no scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	PR only modifies Makefile paths for CRD file locations. No Go source code, test suite setup, or any code that could violate OTE Binary Stdout Contract is changed. Check is not applicable to this PR.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests are present. This PR only modifies a Makefile to update paths for CRD downloads. The check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[deepsm007]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, eggfoobar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [deepsm007]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD ab6ae8f and 2 for PR HEAD 486e5fb in total

[eggfoobar]

/retest-required

[openshift-ci]

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.