Skip to content

Add probes and rollout strategy to component-monitor deployment#79354

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
smg247:component-monitor-readiness
May 15, 2026
Merged

Add probes and rollout strategy to component-monitor deployment#79354
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
smg247:component-monitor-readiness

Conversation

@smg247
Copy link
Copy Markdown
Member

@smg247 smg247 commented May 15, 2026

Wire up startup, readiness, and liveness probes against the new /health endpoint. Add RollingUpdate strategy with maxUnavailable 0 and minReadySeconds 60 so the old pod keeps running until the new one is confirmed ready, preventing monitoring gaps during rollouts.

Summary by CodeRabbit

  • Chores
    • Enhanced deployment strategy with rolling updates to minimize downtime during updates
    • Added health checks to monitor service availability, readiness, and startup status
    • Configured stability thresholds to ensure proper service initialization before accepting traffic

Wire up startup, readiness, and liveness probes against the new /health
endpoint. Add RollingUpdate strategy with maxUnavailable 0 and
minReadySeconds 60 so the old pod keeps running until the new one is
confirmed ready, preventing monitoring gaps during rollouts.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 15, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@smg247: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a3593c9f-d4e0-4c12-bc74-b1304ceac6a0

📥 Commits

Reviewing files that changed from the base of the PR and between ab6ae8f and 9810814.

📒 Files selected for processing (1)
  • clusters/app.ci/ship-status-dash/component-monitor/deployment.yaml

Walkthrough

The Deployment component-monitor is updated with a rolling update strategy that ensures zero unavailable pods during rollouts (maxUnavailable: 0, maxSurge: 1) and a 60-second readiness delay. Three health check probes (startup, readiness, liveness) are added to the container, all using HTTP GET requests to /health on port 8080 with configured timing and failure thresholds.

Changes

Component Monitor Deployment Health & Update Configuration

Layer / File(s) Summary
Health checks and update strategy configuration
clusters/app.ci/ship-status-dash/component-monitor/deployment.yaml
Deployment spec adds RollingUpdate strategy with maxUnavailable: 0 and maxSurge: 1, plus minReadySeconds: 60. Container adds startupProbe, readinessProbe, and livenessProbe, all using HTTP GET on /health port 8080 with initial delays, periods, and failure thresholds.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately and specifically describes the two main changes: adding health check probes and configuring the rollout strategy for the component-monitor deployment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR does not modify any Ginkgo test files. Changes are limited to Kubernetes YAML deployment configuration and non-test Go utility files. Check is not applicable.
Test Structure And Quality ✅ Passed The custom check is for reviewing Ginkgo test code quality, but this PR modifies only Kubernetes deployment YAML configuration. No test files, Ginkgo test blocks, or test code are present in the PR.
Microshift Test Compatibility ✅ Passed This PR modifies only Kubernetes deployment YAML configuration, not e2e tests. The MicroShift Test Compatibility check applies only to new Ginkgo tests, making it not applicable here.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR. Changes are limited to Kubernetes YAML configuration files. The SNO Test Compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed No problematic scheduling constraints found. No affinity rules, nodeSelectors, topology spread constraints, or PDB. Single-replica deployment is topology-safe across all OpenShift topologies.
Ote Binary Stdout Contract ✅ Passed Not applicable - PR only modifies Kubernetes YAML config files. Check applies to binary code with stdout, not infrastructure-as-code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only modifies Kubernetes Deployment manifests (deployment.yaml), not Ginkgo e2e tests. The custom check is not applicable since no new test code is being added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2026
@smg247
Copy link
Copy Markdown
Member Author

smg247 commented May 15, 2026

/hold for openshift-eng/ship-status-dash#91 to deploy

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2026
@sosiouxme
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smg247, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smg247
Copy link
Copy Markdown
Member Author

smg247 commented May 15, 2026

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 15, 2026

@smg247: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 6e6d3a8 into openshift:main May 15, 2026
8 checks passed
@openshift-merge-bot openshift-merge-bot Bot deleted the component-monitor-readiness branch May 15, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants