Add probes and rollout strategy to component-monitor deployment#79354
Conversation
Wire up startup, readiness, and liveness probes against the new /health endpoint. Add RollingUpdate strategy with maxUnavailable 0 and minReadySeconds 60 so the old pod keeps running until the new one is confirmed ready, preventing monitoring gaps during rollouts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe Deployment ChangesComponent Monitor Deployment Health & Update Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/hold for openshift-eng/ship-status-dash#91 to deploy |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smg247, sosiouxme The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
@smg247: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Wire up startup, readiness, and liveness probes against the new /health endpoint. Add RollingUpdate strategy with maxUnavailable 0 and minReadySeconds 60 so the old pod keeps running until the new one is confirmed ready, preventing monitoring gaps during rollouts.
Summary by CodeRabbit