Add ci-operator config for SNO day2-worker 4.18 CI lane#79357
Conversation
Adapts the existing 4.20 sno-day2-worker variant to OpenShift 4.18, using the same infrastructure (kni-qe-106 hub, kni-qe-107 spoke) with 4.18-compatible operator channels (ACM release-2.13, MCE stable-2.8, TALM fbc-4-18, cluster-logging stable-6.1).
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
WalkthroughA new CI-operator configuration YAML file is added for the ChangesCI Configuration Variant
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rdiscala The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml`:
- Line 23: The cron entry "0 0 31 2 *" in the file
openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml is unschedulable
(February has no 31st); replace that cron expression with a valid schedule
(e.g., a valid February date like "0 0 28 2 *" or an alternative monthly
schedule) so the periodic lane actually runs, then follow the CI config workflow
by editing the file under ci-operator/config/<org>/<repo>/ and running make
update to regenerate downstream Prow job configs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: f0ce3fdd-ec34-46a8-badb-63682a312fe6
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml
| - as: cnf-ran-ztp-tests | ||
| capabilities: | ||
| - intranet | ||
| cron: 0 0 31 2 * |
There was a problem hiding this comment.
Cron schedule is unschedulable.
Line 23 uses 0 0 31 2 *, which never triggers (February has no 31st). This effectively disables the periodic lane.
Suggested fix
- cron: 0 0 31 2 *
+ cron: 0 0 * * *📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| cron: 0 0 31 2 * | |
| cron: 0 0 * * * |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml`
at line 23, The cron entry "0 0 31 2 *" in the file
openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml is unschedulable
(February has no 31st); replace that cron expression with a valid schedule
(e.g., a valid February date like "0 0 28 2 *" or an alternative monthly
schedule) so the periodic lane actually runs, then follow the CI config workflow
by editing the file under ci-operator/config/<org>/<repo>/ and running make
update to regenerate downstream Prow job configs.
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
1 participant
Adapts the existing 4.20 sno-day2-worker variant to OpenShift 4.18, using the same infrastructure (kni-qe-106 hub, kni-qe-107 spoke) with 4.18-compatible operator channels (ACM release-2.13, MCE stable-2.8, TALM fbc-4-18, cluster-logging stable-6.1).
This PR adds CI-operator configuration to enable OpenShift CI testing of the
openshift-kni/eco-ci-cdcomponent against OpenShift 4.18 through thecnf-ran-sno-day2-worker-4.18CI lane.The change introduces a new configuration file that establishes a CI variant for testing Single Node OpenShift (SNO) day-2 worker scenarios. It reuses the existing hub and spoke cluster infrastructure (kni-qe-106 and kni-qe-107) and updates the operator channels to 4.18-compatible versions: ACM release-2.13, MCE stable-2.8, TALM fbc-4-18, and cluster-logging stable-6.1. The configuration defines the test environment, resource requirements, and the multi-component operator subscriptions needed for the SNO day-2 worker CI testing scenario.