fix(examples): DSPX-4607 clear goconst and SA1019 lint findings - #3974
Open
dmihalcik-virtru wants to merge 1 commit into
Open
fix(examples): DSPX-4607 clear goconst and SA1019 lint findings#3974dmihalcik-virtru wants to merge 1 commit into
dmihalcik-virtru wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
jakedoublev
previously approved these changes
Sep 3, 2026
This was referenced Sep 4, 2026
Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
dmihalcik-virtru
force-pushed
the
fix/lint-examples-goconst
branch
from
September 4, 2026 13:13
fd8928f to
c40ebca
Compare
policy-bot-opentdf
Bot
dismissed
jakedoublev’s stale review
September 4, 2026 13:13
Invalidated by push of c40ebca
This was referenced Sep 4, 2026
Open
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the DSPX-4607 lint burndown. golangci-lint v2.13.2 (#3965) surfaced 351 pre-existing findings across the repo; they're being cleared as independent PRs grouped by CODEOWNER. This one covers
examples/— 9 findings (8goconst, 1staticcheckSA1019).Changes
goconst(8) — two strings repeated across the benchmark subcommands are now package constants incmd/examples.go:benchmarkCmdShort = "OpenTDF benchmark tool"(3 uses)exampleAttrValueFQN = "https://example.com/attr/attr1/value/value1"(5 uses)Two redundant aliases folded into the new constant while I was there: the
testAttrpackage var inbenchmark_experimental.goand theattrValueFQNlocal inbenchmark_decision_v2.goboth held the same literal.staticcheckSA1019 (1) —cmd/attributes.gosets the deprecatedGetAttributeRequest.Id. Annotated with//nolint:staticcheckper the agreed strategy for this burndown (annotate, don't migrate off deprecated proto fields).No behavior change.
Testing
golangci-lint runoverexamples/→0 issues., under both the current.golangci.yamland the tuned config from chore(ci): DSPX-4607 linter cfg: tune goconst; schema updates #3968 (so this PR is independent of merge order).golangci-lint fmt ./...clean.go build ./...andgo test ./...pass.Related
.golangci.yamlgoconst tuning +gomodguard_v2migrationotdfctl), fix(kas): DSPX-4607 use snake_case slog key in rewrap test fake #3970 (service/kas), chore(core): DSPX-4607 drop stale lib/fixtures nolint directives and reuse keycloakBoolTrue #3971 (lib/fixtures), fix(sdk): DSPX-4607 canonicalize DPoP headers and extract zipstream constants #3973 (sdk) — sibling burndown PRsDSPX-4607 burndown index
.golangci.yamlgoconst tuning +gomodguard_v2migration (merged)otdfctl), fix(kas): DSPX-4607 use snake_case slog key in rewrap test fake #3970 (service/kas), chore(core): DSPX-4607 drop stale lib/fixtures nolint directives and reuse keycloakBoolTrue #3971 (lib/fixtures), fix(sdk): DSPX-4607 canonicalize DPoP headers and extract zipstream constants #3973 (sdk), fix(ci): DSPX-4607 clear tests-bdd goconst, gosec, nestif and sloglint findings #3975 (tests-bdd), fix(policy): DSPX-4607 clear sloglint and SA1019 lint findings #3977 (service/policy), fix(core): DSPX-4607 clear sloglint, goconst, nolintlint and SA1019 findings #3978 (servicecore)