-
Notifications
You must be signed in to change notification settings - Fork 11
fix(groovy): emit ClassRelation for interface inheritance in both engines #1158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8706a8f
fix(groovy): emit ClassRelation for interface inheritance in both eng…
carlos-alm 809b1c7
Merge branch 'main' into fix/1115-groovy-interface-inheritance
carlos-alm 732c82d
fix(groovy): use current node's start line in WASM interface helper (…
carlos-alm c80a561
Merge branch 'main' into fix/1115-groovy-interface-inheritance
carlos-alm 28ebc30
Merge branch 'main' into fix/1115-groovy-interface-inheritance
carlos-alm cda39b5
Merge branch 'main' into fix/1115-groovy-interface-inheritance
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
collectGroovyParentInterfacesreceiveslineonce (the interface declaration'sstartPosition.row + 1) and forwards the same value through every recursive call intotype_listchildren. The Rustcollect_interfacesinstead evaluatesstart_line(interfaces)at each recursive invocation, so it tracks the actual start line of whatever node (extends_interfaces→type_list) is being processed at that moment.For a multi-line interface — e.g.
interface X\n extends Y, Z {}— the Rust engine would emit line 2 for the relation, while the TS engine always emits line 1. This is currently benign (the downstreamHIERARCHY_SOURCE_KINDSfilter doesn't includeinterface), but it means the two engines will produce divergentClassRelation.linevalues once that filter is extended.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 732c82d —
collectGroovyParentInterfacesno longer accepts a fixedlineparameter; it now derivesline = parent.startPosition.row + 1at each recursion level, matching Rust'scollect_interfaceswhich re-evaluatesstart_line(interfaces)per call. Added an engine-parity guard test (interface X\n extends Y, Z {}→ line 2) in both Rust and WASM test suites so this divergence cannot regress.