Set MULTIPART_FILE_LIMIT_EXCEEDED variable#3575
Open
hnakamur wants to merge 2 commits into
Open
Conversation
Member
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the previously-unset MULTIPART_FILE_LIMIT_EXCEEDED transaction variable by assigning it during multipart request-body completion, and updates the multipart regression tests to assert the variable is populated (including the “no limit exceeded” cases).
Changes:
- Set
m_variableMultipartFileLimitExceededfromm_flag_file_limit_exceededinMultipart::multipart_complete(). - Update multipart strict-validation regression expectations so
FLexpands to0(instead of empty). - Add a regression assertion that
MULTIPART_FILE_LIMIT_EXCEEDEDexpands to1whenSecUploadFileLimitis exceeded.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/test-cases/regression/request-body-parser-multipart.json |
Adjusts expected log output to include FL 0 and adds a case asserting FL 1 when the upload file limit is exceeded. |
src/request_body_processor/multipart.cc |
Assigns MULTIPART_FILE_LIMIT_EXCEEDED at multipart completion based on the internal file-limit flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix: cppcheck warnings with version 2.21.0
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



what
MULTIPART_FILE_LIMIT_EXCEEDEDvariable to the appropriate value.why
MULTIPART_FILE_LIMIT_EXCEEDEDvariable was never assigned a value.references