fix: [OCISDEV-848] create empty share files on first sync to stop 404…#613
Open
LarsJurgensen wants to merge 1 commit into
Open
fix: [OCISDEV-848] create empty share files on first sync to stop 404…#613LarsJurgensen wants to merge 1 commit into
LarsJurgensen wants to merge 1 commit into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to get rid of 404 warn logs, when a user has never received a share yet.
The proposed solution in the ticket was implementing a negative cache, keeping track of files that don't exist yet. An in memory cache causes a regression that when a share is created in node A, node B would not see this share until the cache TTL expires. A shared cache (either in NATS or file) is possible, but adds more complexity. I propose initializing empty received.json / created.json files earlier, getting rid of the file not found warnings.