fix unwrap panic with internally tagged enums#1020
Merged
Merged
Conversation
The problem occurs when an internally tagged enum derives its name from the title of the schema. In that situation, if a variant contains a property that is itself a type that requires a name (e.g. a struct), we fail to pass down a name that can be used and fail on the None. Instead, we need to pass down the name we'll eventually choose for the generated enum so that subtypes can derive a name from that root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem occurs when an internally tagged enum derives its name from the title of the schema. In that situation, if a variant contains a property that is itself a type that requires a name (e.g. a struct), we fail to pass down a name that can be used and fail on the None. Instead, we need to pass down the name we'll eventually choose for the generated enum so that subtypes can derive a name from that root.
Closes #1019