Skip to content

feat: Allow more waves for event reward + check max stacks#7249

Open
fabske0 wants to merge 2 commits intopagefaultgames:betafrom
fabske0:event-wave-rewards
Open

feat: Allow more waves for event reward + check max stacks#7249
fabske0 wants to merge 2 commits intopagefaultgames:betafrom
fabske0:event-wave-rewards

Conversation

@fabske0
Copy link
Copy Markdown
Contributor

@fabske0 fabske0 commented Apr 12, 2026

What are the changes the user will see?

Event rewards can now be awarded for Rivals 3-6 additionally to the already existing Rival 1 and 2.
If the item already has max stackes, it will award Balls for the respective Tier

Why am I making these changes?

What are the changes from a developer perspective?

Added other rival waves and a check to see if item is at max stacks

Screenshots/Videos

Details
Give.pokeballs.mp4

How to test the changes?

Event config in timed-events.ts

  {
    name: "TEST",
    eventType: EventType.NO_TIMER_DISPLAY,
    startDate: new Date(Date.UTC(2026, 3, 1)),
    endDate: new Date(Date.UTC(2027, 3, 3)),
    classicWaveRewards: [
      { wave: 8, type: "POKEBALL" },
      { wave: 8, type: "MAP" },
      { wave: 8, type: "AMULET_COIN" },
      { wave: 8, type: "MEGA_BRACELET" },
      { wave: 8, type: "SHINY_CHARM" },
    ],
  },

overrides

const overrides = {
  STARTING_WAVE_OVERRIDE: 8,
  STARTING_LEVEL_OVERRIDE: 9999,
  STARTING_MODIFIER_OVERRIDE: [
    { name: "MAP", count: 1 },
    { name: "AMULET_COIN", count: 5 },
    { name: "MEGA_BRACELET", count: 1 },
    { name: "SHINY_CHARM", count: 4 },
  ],
  POKEBALL_OVERRIDE: {
    active: true,
    pokeballs: {
      [PokeballType.POKEBALL]: 99,
      [PokeballType.GREAT_BALL]: 0,
      [PokeballType.ULTRA_BALL]: 0,
      [PokeballType.ROGUE_BALL]: 0,
      [PokeballType.MASTER_BALL]: 0,
    },
  },
} satisfies Partial<InstanceType<OverridesType>>;

Checklist

  • The PR content is correctly formatted:
    • I'm using beta as my base branch
    • The current branch is not named beta, main or the name of another long-lived feature branch
    • I have provided a clear explanation of the changes within the PR description
    • The PR title matches the Conventional Commits format (as described in CONTRIBUTING.md)
  • The PR is self-contained and cannot be split into smaller PRs
  • There is no overlap with another open PR
  • The PR has been confirmed to work correctly:
    • I have tested the changes manually
    • The full automated test suite still passes (use pnpm test:silent to test locally)
    • I have created new automated tests (pnpm test:create) or updated existing tests related to the PR's changes if necessary
  • I have provided screenshots/videos of the changes (if applicable)
    • I have made sure that any UI changes work for both the default and legacy UI themes (if applicable)

Are there any localization additions or changes? If so:

  • I have created an associated PR on the locales repository
    • If so, include a link to the PR here: _____
  • I have contacted the Translation Team on Discord for proofreading/translation

Does this require any additions or changes to in-game assets? If so:

  • I have created an associated PR on the assets repository
    • If so, include a link to the PR here: _____

@fabske0 fabske0 requested a review from a team as a code owner April 12, 2026 12:50
@fabske0 fabske0 added Item Affects items Event Adds or makes changes to limited-time events labels Apr 12, 2026
Comment thread src/phases/victory-phase.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Event Adds or makes changes to limited-time events Item Affects items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants