feat: Allow more waves for event reward + check max stacks#7249
Open
fabske0 wants to merge 2 commits intopagefaultgames:betafrom
Open
feat: Allow more waves for event reward + check max stacks#7249fabske0 wants to merge 2 commits intopagefaultgames:betafrom
fabske0 wants to merge 2 commits intopagefaultgames:betafrom
Conversation
DayKev
reviewed
Apr 12, 2026
damocleas
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Event rewards can now be awarded for Rivals 3-6 additionally to the already existing Rival 1 and 2.
If the item already has max stackes, it will award Balls for the respective Tier
Why am I making these changes?
What are the changes from a developer perspective?
Added other rival waves and a check to see if item is at max stacks
Screenshots/Videos
Details
Give.pokeballs.mp4
How to test the changes?
Event config in
timed-events.tsoverrides
Checklist
betaas my base branchbeta,mainor the name of another long-lived feature branchpnpm test:silentto test locally)pnpm test:create) or updated existing tests related to the PR's changes if necessaryAre there any localization additions or changes? If so:
Does this require any additions or changes to in-game assets? If so: