Update footer snippet to include new types/enums, fix enumerators exported incorrectly - #45
Merged
Merged
Conversation
Signed-off-by: Param Siddharth <contact@paramsid.com>
Signed-off-by: Param Siddharth <contact@paramsid.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the browser (IIFE) build output so the global Aksharamukha points at the default export while still exposing named exports (enums/helpers), and updates documentation/dependencies accordingly.
Changes:
- Adjust
tsupIIFE footer to merge named exports onto the default export and keep it aswindow.Aksharamukha. - Update README usage to reference
Aksharamukha.Scripts.*instead of raw string literals. - Refresh
package-lock.jsonwith newer dependency resolutions.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tsup.config.ts |
Updates the IIFE footer to preserve named exports on the global default export; adds a TS suppression comment for runtime Node import. |
README.md |
Updates the CDN usage example to use exported Scripts constants. |
package-lock.json |
Bumps resolved versions for various (primarily dev) dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+29
to
+34
| var ns = window.${options.globalName}; | ||
| var main = ns && ns.default ? ns.default : ns; | ||
| if (main && ns) { | ||
| Object.assign(main, ns); | ||
| } | ||
| window.${options.globalName} = main; |
| }, | ||
| onSuccess: async () => { | ||
| // Copy everything from downloads to dist | ||
| // @ts-expect-error Runtime Node import; this TS setup doesn't resolve built-in module types here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update footer snippet to include new types/enums, fix enumerators exported incorrectly
Signed-off-by: Param Siddharth contact@paramsid.com