Fix backdrop-filter prefix being overwritten instead of merged#1284
Open
cscnk52 wants to merge 1 commit into
Open
Fix backdrop-filter prefix being overwritten instead of merged#1284cscnk52 wants to merge 1 commit into
cscnk52 wants to merge 1 commit into
Conversation
When both `backdrop-filter` and `-webkit-backdrop-filter` appear in the same rule, the FallbackHandler previously overwrote the vendor prefix of the first occurrence with the second. This caused the standard declaration to be lost on Chromium and Safari 18+ targets which do not support the WebKit-prefixed variant. Merge prefixes from both declarations and re-resolve against browser targets so that only needed prefixes are emitted. Also fix the Safari upper bound from 17.6 to 18 to cover all versions that require the -webkit- prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both
backdrop-filterand-webkit-backdrop-filterappear in the same rule, the FallbackHandler previously overwrote the vendor prefix of the first occurrence with the second. This caused the standard declaration to be lost on Chromium and Safari 18+ targets which do not support the WebKit-prefixed variant.Merge prefixes from both declarations and re-resolve against browser targets so that only needed prefixes are emitted. Also fix the Safari upper bound from 17.6 to 18 to cover all versions that require the -webkit- prefix.