fix(editor): guard door segments and columnRatios against undefined#303
Open
anton-pascal wants to merge 1 commit into
Open
fix(editor): guard door segments and columnRatios against undefined#303anton-pascal wants to merge 1 commit into
anton-pascal wants to merge 1 commit into
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Add defensive null guards for segments, seg.columnRatios, and seg.dividerThickness in door-system.tsx. Legacy door nodes stored in the database may lack these fields since they were added later to the schema. Without the guard, accessing .length or .some() on undefined crashes the viewer (Sentry EDITOR-AM and escalating 1.8k events).
anton-pascal
force-pushed
the
fix/sentry-EDITOR-AM
branch
from
1e3e602 to
bd789e0
Compare
anton-pascal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sentry issue EDITOR-AM — TypeError:
Cannot read properties of undefined (reading 'length')indoor-system.tsx(487 events) AND escalating issueCannot read properties of undefined (reading 'some')(1.8k events).In
door-system.tsx, the code accessessegments.someandseg.columnRatios.lengthwithout null guards. Legacy door nodes in the database may lack these fields because they were added later to the Zod schema with a default value. When the viewer loads these nodes directly from the DB, the fields areundefined.Fix
segments ?? []for all array iterations.seg.columnRatios ?? [1](matches Zod default).seg.dividerThickness ?? 0.03(matches Zod default).