Skip to content

fix(RhMicronCaretDown): Replace with fill for menus#12532

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:caret-down
Open

fix(RhMicronCaretDown): Replace with fill for menus#12532
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:caret-down

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 29, 2026

Copy link
Copy Markdown
Member

Design reports that filled icon is needed here.

Introduced in #12368.

What: Closes #

Additional issues:

Summary by CodeRabbit

  • UI Updates

    • Updated caret-down toggle visuals across Breadcrumb, Menu/menus, FormSelect, MenuToggle, and SearchInput to use the filled icon variant.
    • Refreshed the demo dropdown indicator to match the updated filled caret-down styling.
  • Documentation

    • Updated React example and demo snippets (Breadcrumb, Menu, CustomMenus, and Modal examples, including deprecated Modal) to use the filled caret-down icon variant and related example imports.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fd5ae2f9-94de-43ec-9069-6ff518acb070

📥 Commits

Reviewing files that changed from the base of the PR and between 6de29bc and 5380267.

⛔ Files ignored due to path filters (11)
  • packages/react-core/src/components/DatePicker/__tests__/__snapshots__/DatePicker.test.tsx.snap is excluded by !**/*.snap
  • packages/react-core/src/components/FormSelect/__tests__/__snapshots__/FormSelect.test.tsx.snap is excluded by !**/*.snap
  • packages/react-core/src/components/MenuToggle/__tests__/__snapshots__/MenuToggle.test.tsx.snap is excluded by !**/*.snap
  • packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationOptionsMenu.test.tsx.snap is excluded by !**/*.snap, !**/generated/**
  • packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap is excluded by !**/*.snap
  • packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap is excluded by !**/*.snap
  • packages/react-templates/src/components/Dropdown/__tests__/__snapshots__/SimpleDropdown.test.tsx.snap is excluded by !**/*.snap
  • packages/react-templates/src/components/Select/__tests__/__snapshots__/CheckboxSelectSnapshots.test.tsx.snap is excluded by !**/*.snap
  • packages/react-templates/src/components/Select/__tests__/__snapshots__/MultiTypeaheadSelect.test.tsx.snap is excluded by !**/*.snap
  • packages/react-templates/src/components/Select/__tests__/__snapshots__/SimpleSelect.test.tsx.snap is excluded by !**/*.snap
  • packages/react-templates/src/components/Select/__tests__/__snapshots__/TypeaheadSelect.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (9)
  • packages/react-core/src/components/Breadcrumb/examples/Breadcrumb.md
  • packages/react-core/src/components/FormSelect/FormSelect.tsx
  • packages/react-core/src/components/Menu/examples/Menu.md
  • packages/react-core/src/components/MenuToggle/MenuToggle.tsx
  • packages/react-core/src/components/Modal/examples/Modal.md
  • packages/react-core/src/components/SearchInput/SearchInput.tsx
  • packages/react-core/src/demos/CustomMenus/CustomMenus.md
  • packages/react-core/src/deprecated/components/Modal/examples/Modal.md
  • packages/react-integration/demo-app-ts/src/components/demos/BreadcrumbDemo/BreadcrumbDemo.tsx
💤 Files with no reviewable changes (2)
  • packages/react-core/src/deprecated/components/Modal/examples/Modal.md
  • packages/react-core/src/components/Modal/examples/Modal.md
✅ Files skipped from review due to trivial changes (7)
  • packages/react-core/src/demos/CustomMenus/CustomMenus.md
  • packages/react-core/src/components/Breadcrumb/examples/Breadcrumb.md
  • packages/react-core/src/components/MenuToggle/MenuToggle.tsx
  • packages/react-core/src/components/FormSelect/FormSelect.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/BreadcrumbDemo/BreadcrumbDemo.tsx
  • packages/react-core/src/components/Menu/examples/Menu.md
  • packages/react-core/src/components/SearchInput/SearchInput.tsx

Walkthrough

Replaces caret-down icon usages with the fill variant in core components, an integration demo, and example markdown files. Also removes an unused caret-down icon import from a Modal example scaffold.

Changes

Caret-down icon fill variant rollout

Layer / File(s) Summary
Component icon swap
packages/react-core/src/components/FormSelect/FormSelect.tsx, packages/react-core/src/components/MenuToggle/MenuToggle.tsx, packages/react-core/src/components/SearchInput/SearchInput.tsx, packages/react-integration/demo-app-ts/src/components/demos/BreadcrumbDemo/BreadcrumbDemo.tsx
Replaces RhMicronsCaretDownIcon imports and rendered toggle icons with RhMicronsCaretDownFillIcon in the component and demo UI code.
Examples and docs updates
packages/react-core/src/components/Breadcrumb/examples/Breadcrumb.md, packages/react-core/src/components/Menu/examples/Menu.md, packages/react-core/src/components/Modal/examples/Modal.md, packages/react-core/src/demos/CustomMenus/CustomMenus.md, packages/react-core/src/deprecated/components/Modal/examples/Modal.md
Updates example imports to the fill caret-down icon and removes the unused caret-down import from the deprecated Modal example scaffold.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
  • thatblindgeye
  • kaylachumley
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: swapping the caret-down icon for the filled variant in menu-related UI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Design reports that filled icon is needed here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants