Add query-time search params and typed scroll cursors#29
Open
srimon12 wants to merge 1 commit into
Open
Conversation
…eries - Introduced `indexed_only` and `quantization` options in the `WITH` clause for search statements. - Updated relevant documentation to reflect new search capabilities. - Enhanced parser and executor to handle new parameters. - Added tests to ensure correct functionality of new features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR syncs the Python implementation with the Go binary for three already-closed gaps:
WITHsupport forindexed_onlyand quantization search paramsINlistsSCROLLnext_offsettype preservationChanges
SearchWithparsing/execution to support:indexed_onlyquantization: { ignore, rescore, oversampling }trueandfalsein filter comparisons andIN/NOT INSCROLLnext_offsetvalues to stringsValidation
Ran:
pytest tests/test_parser.py -qpytest tests/test_executor.py -qpytest tests -qResult:
521 passedWhy
These were already fixed in the Go implementation but still open in Python. This PR removes that behavior drift before we move on to higher-priority work like native MMR.