PDFCLOUD-5550 Add client methods to convert colors in PDF#15
Merged
datalogics-kam merged 11 commits intoFeb 18, 2026
Merged
Conversation
datalogics-gwalczak
changed the title
datalogics-cgreen
changed the title
datalogics-kam
requested changes
Feb 13, 2026
Contributor
datalogics-kam
left a comment
datalogics-kam
left a comment
There was a problem hiding this comment.
Another request to make "custom" into part of the main profile argument, rather than "set this to custom, and then set this other argument"
datalogics-kam
requested changes
Feb 17, 2026
Contributor
datalogics-kam
left a comment
datalogics-kam
left a comment
There was a problem hiding this comment.
Asking for fixups on the color_profile setting.
No Codex findings.
Contributor
|
This needs a rebase for conflict removal |
✅ Deploy Preview for pdfrest-python ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Sorry, this needs a rebase again. |
Assisted-by: Codex
- Add sync/async unit coverage for every PdfColorProfile literal via pytest.param IDs, including custom-profile payload handling. - Add explicit sync/async invalid color_profile tests to assert local ValidationError behavior without issuing HTTP requests. Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
…de checks Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
- Remove `profile` option that duplicated `color_profile` - Accept custom profile upload for `color_profile` without requiring `"custom"` value from user Assisted-by: Codex
Assisted-by: Codex
Update sync and async custom-profile live tests to upload both the source PDF and ICC profile within the same client context that performs `convert_colors`. This avoids intermittent CI failures where reused uploaded IDs can be rejected by the server with "The ID is invalid." Assisted-by: Codex
datalogics-kam
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds convert-colors support to the pdfRest client (sync + async), including a dedicated payload model with validation for PDF inputs, ICC profiles, and output naming, plus a public PdfColorProfile literal enum.
Includes unit tests for request serialization, customization, and validation, and live tests that exercise success and invalid-ID flows against the /pdf-with-converted-colors endpoint.