Skip to content

sql: remove unnecessary 'copy' from FLUSH PRIVILEGES description#23196

Open
yahonda wants to merge 1 commit into
pingcap:release-8.5from
yahonda:fix-flush-privileges-copy
Open

sql: remove unnecessary 'copy' from FLUSH PRIVILEGES description#23196
yahonda wants to merge 1 commit into
pingcap:release-8.5from
yahonda:fix-flush-privileges-copy

Conversation

@yahonda

@yahonda yahonda commented Jul 3, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Align the FLUSH PRIVILEGES description with MySQL documentation. Changed:

  • reload the in-memory copy of privileges from the privilege tables
  • reload the grant tables into memory

MySQL's own documentation at https://dev.mysql.com/doc/refman/8.4/en/privilege-changes.html uses reload the grant tables without copy. TiDB documentation should follow the same concise style.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch

@ti-chi-bot

ti-chi-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the description of the FLUSH PRIVILEGES statement by changing "in-memory copy of privileges" to "in-memory privileges". The reviewer suggested further simplifying the text by removing "in-memory" entirely to avoid unnecessary words, which aligns with the style guide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread sql-statements/sql-statement-flush-privileges.md Outdated
@yahonda yahonda force-pushed the fix-flush-privileges-copy branch from 1ddda69 to cfe6984 Compare July 3, 2026 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant