Decouple azure dns zones in core infra#127
Open
JohnBlackwell wants to merge 4 commits into
Open
Conversation
JohnBlackwell
requested review from
floreks,
maciaszczykm,
michaeljguarino and
zreigz
Member
michaeljguarino
left a comment
michaeljguarino
left a comment
There was a problem hiding this comment.
This pr seems confused to me. A few things:
- We always publish the information of the management dns zone to the management clusters service context, you're trampling that here. it's needed to make sure other wiring works (why there's three service contexts).
- If you're creating additional dns zones, use them wherever needed, so make them be published down to the dev/prod networks if so.
| type = string | ||
| } | ||
|
|
||
| variable "use_mgmt_dns_zone" { |
Member
There was a problem hiding this comment.
is this being set as part of the cli's install for cloud or self-hosted console's?
Contributor
Author
There was a problem hiding this comment.
Both cloud and self-hosted would be using the false default setting. It can be wired in as a variable in the core-infra stack crd if it needs to set to true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core-infra stack was reusing the dev/prod db dns zones created on the mgmt cluster. This PR creates a new set and optionally reads from the mgmt cluster if the
use_mgmt_dns_zonevar on core-infra istrue; defaults tofalse