Migrate Python smoke check to public API runner#119
Merged
Conversation
Finding: [P2] Assert actual Python REPL output — /Users/tomasz/.codex/worktrees/5aad/mcp-repl/tests/run_integration_tests.py:637-638: The migrated Python smoke case can report success on Python startup failures because it only searches for the digit 2 in the returned text. When Python cannot start, such as when PATH lacks the selected python3 or MCP_REPL_PYTHON_EXECUTABLE points to a missing file, the tool returns startup failure text containing os error 2 with isError: false. This lets python-console-basic pass even though 1+1 never ran, so the new public API coverage can mask Python startup failures; assert the expected REPL output shape instead. Response: Added a regression test covering startup failure text with os error 2 and changed python-console-basic to assert the exact normalized MCP tool result for 1+1 output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the basic Python console smoke scenario from the Rust integration suite into the external public API runner.
This continues the public API runner migration by checking Python through the same real-binary MCP stdio path already used for R cases.
User-facing changes
replbehavior through--interpreter python.Internal changes
python-console-basicrunner case with files-mode Python server arguments.python_smokeintegration test.