Skip to content

add write-manifest pyproject command#782

Merged
amol- merged 3 commits into
mainfrom
write-manifest-pyproject
Jun 16, 2026
Merged

add write-manifest pyproject command#782
amol- merged 3 commits into
mainfrom
write-manifest-pyproject

Conversation

@amol-

@amol- amol- commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Intent

For connect git based deployment a manifest.json is required.
Manually maintaining a manifest.json is not very convenient and it's also fairly verbose,
the support for pyproject.toml metadata makes much easier to maintain the important metadata values which then rsconnect deploy pyproject reads.

This is meant to implement support for pyproject.toml in the write-manifest command: rsconnect write-manifest pyproject, thus allowing users to keep pyproject.toml as their only source of truth and generate the manifest on demand from it (it is not required for normal deploys as rsconnect deploy pyproject can be used for those)

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

  • refactor pyproject.toml metadata parsing from deploy pyproject so that it can be shared between deploy and write-manifest
  • add a write-manifest command that reads the pyproject and creates the corresponding manifest for that app type reusing the already existing write manifest logic.

Automated Tests

  • added dedicated test suite

Directions for Reviewers

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.
  • I have run the rsconnect-python-tests-at-night workflow in Connect against this feature branch.

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-06-16 17:48 UTC

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7029 5699 81% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/main.py 79% 🟢
rsconnect/pyproject.py 98% 🟢
TOTAL 89% 🟢

updated for commit: c23ce93 by action🐍

@amol- amol- marked this pull request as ready for review June 11, 2026 16:42
@amol- amol- requested a review from jonkeane June 11, 2026 16:42
@amol- amol- merged commit a98e649 into main Jun 16, 2026
23 checks passed
@amol- amol- deleted the write-manifest-pyproject branch June 16, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants