Skip to content

Revert "Merge #225"#247

Merged
bors[bot] merged 2 commits into
ppb:masterfrom
AstraLuma:undo-ci-docker
May 5, 2019
Merged

Revert "Merge #225"#247
bors[bot] merged 2 commits into
ppb:masterfrom
AstraLuma:undo-ci-docker

Conversation

@AstraLuma

Copy link
Copy Markdown
Member

This rolls back the use of CI dockerfiles, so that cirrus brokenness no longer blocks other PRs.

This is not a rejection of #240.

This reverts commit 8598c08, reversing
changes made to edd7499.
@AstraLuma
AstraLuma requested a review from a team as a code owner May 4, 2019 19:10
@pathunstrom

Copy link
Copy Markdown
Collaborator

bors r+

bors Bot added a commit that referenced this pull request May 5, 2019
247: Revert "Merge #225" r=pathunstrom a=astronouth7303

This rolls back the use of CI dockerfiles, so that cirrus brokenness no longer blocks other PRs.

This is not a rejection of #240.

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@bors

bors Bot commented May 5, 2019

Copy link
Copy Markdown
Contributor

Build succeeded

  • docs
  • Linux container:python:3.6-slim
  • Linux container:python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • Windows container:python:3.6-windowsservercore-1809
  • Windows container:python:3.7-windowsservercore-1809

@bors
bors Bot merged commit 19e2ba2 into ppb:master May 5, 2019
@nicoonoclaste

Copy link
Copy Markdown
Contributor

Thanks for doing that <3

I need to revisit #240, but TBH I've been too frustrated with the quoting mess... :(

@AstraLuma
AstraLuma deleted the undo-ci-docker branch May 19, 2019 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants