Fix skip overlay issue on multiplayer freestyle#38300
Conversation
… free style. When there are different difficulties been selected by multiple users, the total required skip count will only be based on the number of players choosing the same diffculties However, this only change the overlays in game but did not change how game server behave. Same issue also founded in osu-web-spectator, which needed to adjusted later.
… free style. When there are different difficulties been selected by multiple users, the total required skip count will only be based on the number of players choosing the same diffculties However, this only change the overlays in game but did not change how game server behave. Same issue also founded in osu-web-spectator, which needed to adjusted later.
|
I've read the OP like 10 times and I don't get it. I think it might read back to front or something. |
Sorry. I have updated the OP |
|
So the problematic case is where some difficulties don't have a skip option? I'm not sure this is the correct fix if so. |
For example, there is a set of beatmaps with different difficulties, like the following beatmaps This is where the bug is. |
2 participants
In a multiplayer room, sometimes different players in the same room will choose different difficulties. During the play, a vote will be offered for everyone to decide whether the game should skip the intro.
As described in #38291, the bug is that the number of people required to vote for skipping is based on the total number of people in the room instead of the number of players of the same difficulty. This bug happens in both skip overlays and osu-server-spectator.
This PR fixes this bug with in-game overlays and adds a test for this scenario. Now the in-game multiplayer skip overlay will show the correct number of people required to skip the intro. However, the bug in osu-server-spectator still remains.
osu-sever-spectator issue:ppy/osu-server-spectator#526