Conversation
Collaborator
Author
lminiero
requested changes
Mar 16, 2026
Collaborator
lminiero
left a comment
lminiero
left a comment
There was a problem hiding this comment.
As it is, the PR still causes issues for me. It may be because the commit that's listed as good (b84869f41414b6d0148db7728f1cf12f5b544874) has only been changed in the CI scripts, but not in CMakeLists.txt. If I set it there too, it does work.
Collaborator
Author
|
Changing the commit in CMakeList as well. I hope that finally solves the issue. |
Collaborator
Author
|
@lminiero does the PR meets your requirements now? |
Collaborator
Sorry, I was busy during the first IETF session of the morning. I just tested and it works now, thanks! |
Collaborator
Author
|
Thanks for the review, @lminiero. And thanks for doing that in the middle of hectic beginning of the IETF! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make sure that all github actions use checkout@v5 instead of checkout@v3 or v2, in order to address issue #2067
update ci scripts to latest commit of picotls to address issue #2068