Skip to content

Fix missing finalizers in the ArgoCD app#174

Merged
DebakelOrakel merged 1 commit intomasterfrom
bug/argocd-app-finalizers
Apr 13, 2026
Merged

Fix missing finalizers in the ArgoCD app#174
DebakelOrakel merged 1 commit intomasterfrom
bug/argocd-app-finalizers

Conversation

@DebakelOrakel
Copy link
Copy Markdown
Contributor

@DebakelOrakel DebakelOrakel commented Apr 13, 2026

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@DebakelOrakel DebakelOrakel added bug Something isn't working bump:patch labels Apr 13, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 13, 2026

🚀 This PR has been released as v5.8.1

Triggering workflows Release

🛠️ Auto tagging enabled with label bump:patch

@DebakelOrakel DebakelOrakel force-pushed the bug/argocd-app-finalizers branch from 7a37d39 to e676045 Compare April 13, 2026 09:06
Comment thread component/app.jsonnet
@DebakelOrakel DebakelOrakel requested a review from simu April 13, 2026 11:08
Copy link
Copy Markdown
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now. I would like to understand when/how those additional finalizers are relevant and whether it's fine to just add them everywhere.

@DebakelOrakel DebakelOrakel merged commit 9b84d63 into master Apr 13, 2026
9 checks passed
@DebakelOrakel DebakelOrakel deleted the bug/argocd-app-finalizers branch April 13, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working bump:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants