Feat/build

[kooksee]

No description provided.

[gemini-code-assist]

Code Review

This pull request introduces Zig build support (build.zig) alongside helper scripts to cross-compile static dependencies for macOS and musl/Linux, enabling fully static or portable binaries. It also resolves several cross-platform compatibility issues for macOS/BSD in config.c, plugins/telnetd.c, and utils.c. Feedback on these changes includes increasing the MAC address buffer validation length to 13 to prevent truncation, fixing a formatting regression in telnetd.c, adding libevent_openssl.a to the dependency cache checks in both build scripts, and avoiding overriding exported LDFLAGS and CPPFLAGS when configuring libevent on macOS.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

The validation check mac_len < 12 is insufficient. A MAC address formatted as 12 hexadecimal characters (e.g., XXXXXXXXXXXX) requires at least 13 bytes to include the null terminator (\0). If mac_len is exactly 12, the loop formatting the MAC address will pass a size of 2 to snprintf for the last byte (i = 5), which truncates the last character and results in an incomplete 11-character MAC address string. Increasing the minimum required length to 13 prevents this truncation.

Suggested change

	if (!net_if_name || !mac || mac_len < 12) {
	return 1;
	}
	if (!net_if_name || !mac || mac_len < 13) {
	return 1;
	}

[gemini-code-assist]

Formatting regression: multiple statements are placed on a single line separated by tabs. This reduces readability and violates standard C formatting guidelines. Please split them back into separate lines.

		termbuf.c_oflag |= ONLCR | XTABS;
		termbuf.c_iflag |= ICRNL;

[gemini-code-assist]

The have_all_libs check is missing a check for libevent_openssl.a. Since build.zig explicitly links against event_openssl, if libevent_openssl.a is missing but other libraries are present, the script will incorrectly skip the build, leading to compilation failures later. Adding libevent_openssl.a to the check ensures build completeness.

Suggested change

	have_all_libs() {
	[ -f "$SYSROOT/lib/libz.a" ] &&
	[ -f "$SYSROOT/lib/libevent.a" ] &&
	[ -f "$SYSROOT/lib/libjson-c.a" ] &&
	{ [ -f "$SYSROOT/lib/libssl.a" ] || [ -f "$SYSROOT/lib64/libssl.a" ]; } &&
	{ [ -f "$SYSROOT/lib/libcrypto.a" ] || [ -f "$SYSROOT/lib64/libcrypto.a" ]; }
	}
	have_all_libs() {
	[ -f "$SYSROOT/lib/libz.a" ] &&
	[ -f "$SYSROOT/lib/libevent.a" ] &&
	[ -f "$SYSROOT/lib/libevent_openssl.a" ] &&
	[ -f "$SYSROOT/lib/libjson-c.a" ] &&
	{ [ -f "$SYSROOT/lib/libssl.a" ] || [ -f "$SYSROOT/lib64/libssl.a" ]; } &&
	{ [ -f "$SYSROOT/lib/libcrypto.a" ] || [ -f "$SYSROOT/lib64/libcrypto.a" ]; }
	}

[gemini-code-assist]

The have_all_libs check is missing a check for libevent_openssl.a. Since build.zig explicitly links against event_openssl, if libevent_openssl.a is missing but other libraries are present, the script will incorrectly skip the build, leading to compilation failures later. Adding libevent_openssl.a to the check ensures build completeness.

Suggested change

	have_all_libs() {
	[ -f "$SYSROOT/lib/libz.a" ] &&
	[ -f "$SYSROOT/lib/libevent.a" ] &&
	[ -f "$SYSROOT/lib/libjson-c.a" ] &&
	{ [ -f "$SYSROOT/lib/libssl.a" ] || [ -f "$SYSROOT/lib64/libssl.a" ]; } &&
	{ [ -f "$SYSROOT/lib/libcrypto.a" ] || [ -f "$SYSROOT/lib64/libcrypto.a" ]; }
	}
	have_all_libs() {
	[ -f "$SYSROOT/lib/libz.a" ] &&
	[ -f "$SYSROOT/lib/libevent.a" ] &&
	[ -f "$SYSROOT/lib/libevent_openssl.a" ] &&
	[ -f "$SYSROOT/lib/libjson-c.a" ] &&
	{ [ -f "$SYSROOT/lib/libssl.a" ] || [ -f "$SYSROOT/lib64/libssl.a" ]; } &&
	{ [ -f "$SYSROOT/lib/libcrypto.a" ] || [ -f "$SYSROOT/lib64/libcrypto.a" ]; }
	}

[gemini-code-assist]

Overriding LDFLAGS and CPPFLAGS as arguments to ./configure for libevent removes the exported LDFLAGS which contains the crucial -arch $ARCH and -mmacosx-version-min=11.0 flags. Since they are already exported, they do not need to be passed as arguments. Removing them ensures that the correct architecture and deployment target flags are preserved during compilation.

Suggested change

	./configure --host="$HOST_TRIPLE" --disable-shared --enable-static \
	--disable-samples --disable-libevent-regress --disable-debug-mode \
	--prefix="$SYSROOT" \
	CPPFLAGS="-I$SYSROOT/include" LDFLAGS="-L$SYSROOT/lib"
	./configure --host="$HOST_TRIPLE" --disable-shared --enable-static \
	--disable-samples --disable-libevent-regress --disable-debug-mode \
	--prefix="$SYSROOT"