Rename build files from TARGETS to BUCK (group ID: 1746601514138727150)#19419
Rename build files from TARGETS to BUCK (group ID: 1746601514138727150)#19419bigfootjon wants to merge 1 commit intomainfrom
Conversation
Reviewed By: bigfootjon Differential Revision: D104414856
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19419
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 5 PendingAs of commit 594fc77 with merge base 9889c7c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414856. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR migrates Buck build definitions away from TARGETS toward BUCK files and introduces build-file migration wrappers to support fbcode vs non-fbcode target definitions within the same build file.
Changes:
- Wrap XNNPACK Python library targets with
fbcode_target(...)and add migration macro imports. - Remove
backends/vulkan/tools/gpuinfo/TARGETSand merge its target definitions intobackends/vulkan/tools/gpuinfo/BUCK. - Introduce
fbcode_target/non_fbcode_targetwrappers for Vulkan gpuinfo targets to support environment-specific deps.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| backends/xnnpack/recipes/BUCK | Wraps python_library targets with migration macro and adds build migration load. |
| backends/xnnpack/quantizer/BUCK | Wraps python_library targets with migration macro and adds build migration load. |
| backends/xnnpack/partition/config/BUCK | Wraps python_library target with migration macro and adds build migration load. |
| backends/vulkan/tools/gpuinfo/TARGETS | Removes legacy TARGETS file after merging content into BUCK. |
| backends/vulkan/tools/gpuinfo/BUCK | Wraps existing targets with non_fbcode_target and appends fbcode equivalents from deleted TARGETS. |
Comments suppressed due to low confidence (3)
backends/xnnpack/recipes/BUCK:1
non_fbcode_targetis loaded but never used in this file. This can trigger build/lint failures for unused loaded symbols; remove it from theload()list (or switch usages tonon_fbcode_targetif that was intended).
backends/xnnpack/quantizer/BUCK:1non_fbcode_targetis loaded but never used in this file. This can trigger build/lint failures for unused loaded symbols; remove it from theload()list (or switch usages tonon_fbcode_targetif that was intended).
backends/xnnpack/partition/config/BUCK:1non_fbcode_targetis loaded but never used in this file. This can trigger build/lint failures for unused loaded symbols; remove it from theload()list (or switch usages tonon_fbcode_targetif that was intended).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| load("@fbcode_macros//build_defs:native_rules.bzl", "buck_filegroup") | ||
| load("@fbsource//tools/build_defs:fb_xplat_cxx_binary.bzl", "fb_xplat_cxx_binary") | ||
| load( | ||
| "@fbsource//tools/build_defs:platform_defs.bzl", | ||
| "ANDROID", | ||
| ) | ||
| load( | ||
| "@fbsource//xplat/executorch/backends/vulkan:targets.bzl", | ||
| "vulkan_spv_shader_lib", | ||
| ) | ||
|
|
||
|
|
| @@ -21,14 +22,14 @@ buck_filegroup( | |||
| ], | |||
| ) | |||
|
|
|||
| vulkan_spv_shader_lib( | |||
| non_fbcode_target(_kind = vulkan_spv_shader_lib, | |||
| name = "gpuinfo_shader_lib", | |||
| spv_filegroups = { | |||
| ":gpuinfo_shaders": "glsl", | |||
| }, | |||
| ) | |||
|
|
|||
| fb_xplat_cxx_binary( | |||
| non_fbcode_target(_kind = fb_xplat_cxx_binary, | |||
| name = "vulkan_gpuinfo", | |||
Reviewed By: bigfootjon
Differential Revision: D104414856