Rename build files from TARGETS to BUCK (group ID: -7829286582326892371) (#19420)#19420
Rename build files from TARGETS to BUCK (group ID: -7829286582326892371) (#19420)#19420bigfootjon wants to merge 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19420
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 9636bf0 with merge base 4413a5c ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104415426. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Migrates ExecuTorch devtools Buck build definitions by consolidating legacy TARGETS content into BUCK files and wrapping targets using the build-file migration macros, aligning these directories with the BUCK-based build file naming/layout.
Changes:
- Removed
devtools/bundled_program/TARGETSand merged its rules intodevtools/bundled_program/BUCK. - Updated several
devtools/**/BUCKfiles to wrap rule definitions withfbcode_target(and, where applicable,non_fbcode_target) viabuild_file_migration.bzl. - Preserved existing target structure (names/deps/visibility) while shifting to the new wrapper-based declaration style.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| devtools/bundled_program/TARGETS | Removed legacy build file after merging its rules into BUCK. |
| devtools/bundled_program/BUCK | Adds migration wrappers and incorporates the previous TARGETS python library definitions. |
| devtools/BUCK | Wraps the lib python_library rule with fbcode_target for migration compatibility. |
| devtools/backend_debug/BUCK | Wraps the delegation_info python_library rule with fbcode_target. |
| devtools/backend_debug/tests/BUCK | Wraps the test_delegation_info unittest rule with fbcode_target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
04ce966 to
9636bf0
Compare
Summary: Pull Request resolved: #19420
Reviewed By: bigfootjon
Differential Revision: D104415426