Skip to content

Rename build files from TARGETS to BUCK (group ID: -7829286582326892371) (#19420)#19420

Open
bigfootjon wants to merge 1 commit intomainfrom
export-D104415426
Open

Rename build files from TARGETS to BUCK (group ID: -7829286582326892371) (#19420)#19420
bigfootjon wants to merge 1 commit intomainfrom
export-D104415426

Conversation

@bigfootjon
Copy link
Copy Markdown
Member

@bigfootjon bigfootjon commented May 8, 2026

Summary: Pull Request resolved: #19420

Reviewed By: bigfootjon

Differential Revision: D104415426

Copilot AI review requested due to automatic review settings May 8, 2026 23:20
@bigfootjon bigfootjon requested a review from Gasoonjia as a code owner May 8, 2026 23:20
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 8, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19420

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 9636bf0 with merge base 4413a5c (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 8, 2026

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104415426.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates ExecuTorch devtools Buck build definitions by consolidating legacy TARGETS content into BUCK files and wrapping targets using the build-file migration macros, aligning these directories with the BUCK-based build file naming/layout.

Changes:

  • Removed devtools/bundled_program/TARGETS and merged its rules into devtools/bundled_program/BUCK.
  • Updated several devtools/**/BUCK files to wrap rule definitions with fbcode_target (and, where applicable, non_fbcode_target) via build_file_migration.bzl.
  • Preserved existing target structure (names/deps/visibility) while shifting to the new wrapper-based declaration style.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
devtools/bundled_program/TARGETS Removed legacy build file after merging its rules into BUCK.
devtools/bundled_program/BUCK Adds migration wrappers and incorporates the previous TARGETS python library definitions.
devtools/BUCK Wraps the lib python_library rule with fbcode_target for migration compatibility.
devtools/backend_debug/BUCK Wraps the delegation_info python_library rule with fbcode_target.
devtools/backend_debug/tests/BUCK Wraps the test_delegation_info unittest rule with fbcode_target.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…71) (#19420)

Summary: Pull Request resolved: #19420

Reviewed By: bigfootjon

Differential Revision: D104415426
@meta-codesync meta-codesync Bot changed the title Rename build files from TARGETS to BUCK (group ID: -7829286582326892371) Rename build files from TARGETS to BUCK (group ID: -7829286582326892371) (#19420) May 9, 2026
@bigfootjon bigfootjon force-pushed the export-D104415426 branch from 04ce966 to 9636bf0 Compare May 9, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants