Rename build files from TARGETS to BUCK (group ID: 3407902480605305541) (#19422)#19422
Rename build files from TARGETS to BUCK (group ID: 3407902480605305541) (#19422)#19422bigfootjon wants to merge 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19422
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 10c494e with merge base 4413a5c ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414913. |
There was a problem hiding this comment.
Pull request overview
Renames Buck build definition files from TARGETS to BUCK in a couple of devtools areas, using fbcode_target / non_fbcode_target wrappers to keep fbcode vs xplat definitions gated appropriately.
Changes:
- Remove
TARGETSfiles and add equivalentBUCKfiles. - Wrap migrated target definitions with
fbcode_target/non_fbcode_target. - Merge an fbcode-only
runtime.python_librarytarget into the newBUCKfor bundled program schema.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| devtools/etdump/data_sinks/tests/TARGETS | Deleted in favor of BUCK migration. |
| devtools/etdump/data_sinks/tests/BUCK | New BUCK file for data_sinks tests, currently only gated for fbcode. |
| devtools/bundled_program/schema/TARGETS | Deleted after merging targets into BUCK. |
| devtools/bundled_program/schema/BUCK | BUCK now contains both non-fbcode (xplat) and fbcode-gated targets after migration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| oncall("executorch") | ||
|
|
||
| fbcode_target(_kind = define_common_targets,) |
| load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") | ||
| oncall("executorch") | ||
| # Any targets that should be shared between fbcode and xplat must be defined in | ||
| # targets.bzl. This file can contain xplat-only targets. |
| # targets.bzl. This file can contain fbcode-only targets. | ||
|
|
||
| load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime") | ||
| load(":targets.bzl", "define_common_targets") |
300af5a to
10c494e
Compare
Summary: Pull Request resolved: #19422
Reviewed By: bigfootjon
Differential Revision: D104414913