Rename build files from TARGETS to BUCK (group ID: -1063234892916970392)#19424
Rename build files from TARGETS to BUCK (group ID: -1063234892916970392)#19424bigfootjon wants to merge 1 commit intomainfrom
Conversation
Reviewed By: bigfootjon Differential Revision: D104414963
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19424
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 5 PendingAs of commit 479ecf2 with merge base 9889c7c ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414963. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Migrates extension/pytree Buck build definitions from separate TARGETS (fbcode) + BUCK (xplat) files into unified BUCK files using fbcode_target / non_fbcode_target wrappers, and updates one existing BUCK file to use the migration wrapper.
Changes:
- Deleted
TARGETSfiles underextension/pytree/**and merged their fbcode-only rules into the correspondingBUCKfiles. - Added
build_file_migration.bzlwrappers to select fbcode vs non-fbcode target definitions from a singleBUCK. - Wrapped
extension/pybindings/test/BUCKrules withfbcode_target.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| extension/pytree/TARGETS | Deleted; fbcode-only targets moved into extension/pytree/BUCK. |
| extension/pytree/BUCK | Now contains both non-fbcode and fbcode target definitions via migration wrappers. |
| extension/pytree/aten_util/TARGETS | Deleted; contents migrated into extension/pytree/aten_util/BUCK. |
| extension/pytree/aten_util/BUCK | Now dispatches common targets via non_fbcode_target / fbcode_target. |
| extension/pytree/aten_util/test/TARGETS | Deleted; contents migrated into extension/pytree/aten_util/test/BUCK. |
| extension/pytree/aten_util/test/BUCK | Now dispatches common targets via non_fbcode_target / fbcode_target. |
| extension/pybindings/test/BUCK | Wraps existing python rules with fbcode_target and loads migration helpers. |
Comments suppressed due to low confidence (1)
extension/pybindings/test/BUCK:2
- non_fbcode_target is loaded here but not used anywhere in the file. Removing unused loads makes it clearer which targets are intended to be fbcode-vs-xplat and reduces migration boilerplate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") | ||
| oncall("executorch") | ||
| # Any targets that should be shared between fbcode and xplat must be defined in | ||
| # targets.bzl. This file can contain xplat-only targets. |
| define_common_targets() | ||
| non_fbcode_target(_kind = define_common_targets,) | ||
|
|
||
| # !!!! fbcode/executorch/extension/pytree/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! |
| # targets.bzl. This file can contain fbcode-only targets. | ||
|
|
||
| load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime") | ||
| load(":targets.bzl", "define_common_targets") |
|
|
||
| # Any targets that should be shared between fbcode and xplat must be defined in | ||
| # targets.bzl. This file can contain fbcode-only targets. | ||
| load(":targets.bzl", "define_common_targets") |
| load(":targets.bzl", "define_common_targets") | ||
|
|
||
|
|
Reviewed By: bigfootjon
Differential Revision: D104414963