Skip to content

Rename build files from TARGETS to BUCK (group ID: -3982651347005005195)#19427

Open
bigfootjon wants to merge 1 commit intomainfrom
export-D104414874
Open

Rename build files from TARGETS to BUCK (group ID: -3982651347005005195)#19427
bigfootjon wants to merge 1 commit intomainfrom
export-D104414874

Conversation

@bigfootjon
Copy link
Copy Markdown
Member

Reviewed By: bigfootjon

Differential Revision: D104414874

Reviewed By: bigfootjon

Differential Revision: D104414874
Copilot AI review requested due to automatic review settings May 8, 2026 23:21
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 8, 2026

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414874.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 8, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19427

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 3 Pending, 1 Unclassified Failure

As of commit 0e2e4f0 with merge base 9889c7c (image):
💚 Looks good so far! There are no failures yet. 💚

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

  • Check Labels (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates a few extension build definitions from TARGETS files into BUCK files, aligning with the repository’s build-file naming/migration approach and enabling conditional fbcode vs non-fbcode target definitions via migration macros.

Changes:

  • Removed TARGETS files under extension/tensor and extension/runner_util (and extension/runner_util/test).
  • Updated corresponding BUCK files to use fbcode_target / non_fbcode_target wrappers around existing define_common_targets entrypoints.
  • Updated extension/pytree/test/BUCK to wrap test rules with fbcode_target.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
extension/tensor/TARGETS Removed legacy TARGETS file now merged into BUCK.
extension/tensor/BUCK Adds migration macro wrappers for fbcode/non-fbcode target definition.
extension/runner_util/TARGETS Removed legacy TARGETS file now merged into BUCK.
extension/runner_util/BUCK Adds migration macro wrappers for fbcode/non-fbcode target definition.
extension/runner_util/test/TARGETS Removed legacy TARGETS file now merged into BUCK.
extension/runner_util/test/BUCK Adds migration macro wrappers; fbcode path passes is_fbcode=True.
extension/pytree/test/BUCK Wraps unittest targets in fbcode_target for migration compatibility.
Comments suppressed due to low confidence (1)

extension/pytree/test/BUCK:1

  • non_fbcode_target is loaded but never used in this file. Dropping the unused symbol from the build_file_migration.bzl load would reduce noise and avoid confusion about whether a non-fbcode version of these tests is expected.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread extension/tensor/BUCK
Comment on lines +13 to +18
# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain fbcode-only targets.

load(":targets.bzl", "define_common_targets")


# !!!! fbcode/executorch/extension/runner_util/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!!

# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain xplat-only targets.
Comment on lines 13 to +19
# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain xplat-only targets.

load(":targets.bzl", "define_common_targets")

oncall("executorch")

define_common_targets()
fbcode_target(_kind = define_common_targets,)
# !!!! fbcode/executorch/extension/runner_util/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!!

# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain xplat-only targets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants