Rename build files from TARGETS to BUCK (group ID: 706341641191688314)#19432
Rename build files from TARGETS to BUCK (group ID: 706341641191688314)#19432bigfootjon wants to merge 1 commit intomainfrom
Conversation
Reviewed By: bigfootjon Differential Revision: D104415372
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19432
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No Failures, 1 Unclassified FailureAs of commit bba1233 with merge base 9889c7c ( UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104415372. |
There was a problem hiding this comment.
Pull request overview
Renames Qualcomm backend Buck build files from TARGETS to BUCK and updates the build definitions to use the build_file_migration.bzl wrappers, aligning these directories with the repo’s ongoing Buck build-file migration approach.
Changes:
- Remove
TARGETSbuild files underbackends/qualcomm/{partition,builders,aot/wrappers}. - Add/modify
BUCKfiles in those directories to call the shareddefine_common_targetsvia migration wrappers. - Update
backends/qualcomm/debugger/BUCKto wrap existingruntime.python_librarytargets withfbcode_target.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| backends/qualcomm/partition/TARGETS | Deletes legacy TARGETS build entrypoint. |
| backends/qualcomm/partition/BUCK | Adds new BUCK entrypoint using migration macros to invoke define_common_targets. |
| backends/qualcomm/debugger/BUCK | Wraps existing python library rules with fbcode_target for migration compatibility. |
| backends/qualcomm/builders/TARGETS | Deletes legacy TARGETS build entrypoint. |
| backends/qualcomm/builders/BUCK | Migrates shared target definition invocation using non_fbcode_target/fbcode_target. |
| backends/qualcomm/aot/wrappers/TARGETS | Deletes legacy TARGETS build entrypoint. |
| backends/qualcomm/aot/wrappers/BUCK | Migrates shared target definition invocation using non_fbcode_target/fbcode_target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reviewed By: bigfootjon
Differential Revision: D104415372