Skip to content

Rename build files from TARGETS to BUCK (group ID: 706341641191688314)#19432

Open
bigfootjon wants to merge 1 commit intomainfrom
export-D104415372
Open

Rename build files from TARGETS to BUCK (group ID: 706341641191688314)#19432
bigfootjon wants to merge 1 commit intomainfrom
export-D104415372

Conversation

@bigfootjon
Copy link
Copy Markdown
Member

Reviewed By: bigfootjon

Differential Revision: D104415372

Reviewed By: bigfootjon

Differential Revision: D104415372
Copilot AI review requested due to automatic review settings May 8, 2026 23:23
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 8, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19432

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures, 1 Unclassified Failure

As of commit bba1233 with merge base 9889c7c (image):
💚 Looks good so far! There are no failures yet. 💚

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 8, 2026

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104415372.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames Qualcomm backend Buck build files from TARGETS to BUCK and updates the build definitions to use the build_file_migration.bzl wrappers, aligning these directories with the repo’s ongoing Buck build-file migration approach.

Changes:

  • Remove TARGETS build files under backends/qualcomm/{partition,builders,aot/wrappers}.
  • Add/modify BUCK files in those directories to call the shared define_common_targets via migration wrappers.
  • Update backends/qualcomm/debugger/BUCK to wrap existing runtime.python_library targets with fbcode_target.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
backends/qualcomm/partition/TARGETS Deletes legacy TARGETS build entrypoint.
backends/qualcomm/partition/BUCK Adds new BUCK entrypoint using migration macros to invoke define_common_targets.
backends/qualcomm/debugger/BUCK Wraps existing python library rules with fbcode_target for migration compatibility.
backends/qualcomm/builders/TARGETS Deletes legacy TARGETS build entrypoint.
backends/qualcomm/builders/BUCK Migrates shared target definition invocation using non_fbcode_target/fbcode_target.
backends/qualcomm/aot/wrappers/TARGETS Deletes legacy TARGETS build entrypoint.
backends/qualcomm/aot/wrappers/BUCK Migrates shared target definition invocation using non_fbcode_target/fbcode_target.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants