Model Designer updates plus text colors#10787
Conversation
|
|
||
| .. list-table:: | ||
| :header-rows: 1 | ||
| :widths: 25 35 40 |
There was a problem hiding this comment.
Unless there was already an order I didn't get, what about trying to sort the table to put close items closer, i.e. number-> text -> boolean -> enum -> vector -> raster -> file type -> others. We can also start with (boolean -> enum). Feel free to adjust suggestion.
There was a problem hiding this comment.
I set the same order as in the issue report, but yes it makes sense to reorder it..
| html_css_files = ['custom.css'] | ||
| if html_context['isTesting'] or html_context['outdated']: | ||
| html_css_files = ['css/qgis_topbar.css'] | ||
| html_css_files.append('css/qgis_topbar.css') |
There was a problem hiding this comment.
Is this correct? I fail to find what the custom.css file refers to
There was a problem hiding this comment.
I don't know if there is a dedicated issue report for this or if it has already been described, but the docked panel on the right showing properties of the selected parameter seems to be a recent feature. Mind checking if it is documented, please? Thanks.
There was a problem hiding this comment.
I would like to address this in the another PR (related to #10814 )
|
|
||
|
|
||
| Socket Types | ||
| ............ |
There was a problem hiding this comment.
If you add a subsection here, I'd suggest to split the section with more, otherwise, it looks weird to have a single subsection and part of the texts (starting from line 512) has nothing to do with your new section
|
|
||
| html_css_files = ['css/qgis_docs.css'] | ||
| if html_context['isTesting'] or html_context['outdated']: | ||
| html_css_files = ['css/qgis_topbar.css'] | ||
| html_css_files.append('css/qgis_topbar.css') |
There was a problem hiding this comment.
I don't think changing this block is necessary at all. I have hard time understanding the ideal structure for Sphinx and RTD theme but since qgis_docs.css is already referenced in its parent rtd_theme conf file, and the settings work, I'd be careful not to complicate the relations/dependencies.
Unless it's proved necessary.
There was a problem hiding this comment.
Indeed it is unnecessary... I'm learning how to do changes like this, so sorry for the mess 😃
There was a problem hiding this comment.
My request was to remove your changes but it looks like removing the whole block doesn't break anything. So far so good. Let's merge and keep eyes on it...
2 participants
fix #10559
fix #10648
Text color codes for socket types added.
Changes (colors):
HTML
PDF
