Conversation
| * 2 --- removing from current selection | ||
| * 3 --- selecting within current selection |
There was a problem hiding this comment.
@alexbruy Considering the drop-down in GUI, and the generated code when run in master, I think these enums should also be switched. May apply elsewhere.
There was a problem hiding this comment.
@DelazJ Sorry, I do not see how your comment is related to the pull-request. This pull-request only updates algorithms IDs and does not touch anything related to enums or makes changes to other parts of the documentation.
There was a problem hiding this comment.
@alexbruy This is what I get running qgis/QGIS@97f70693986
Note that the order between "selecting" and "removing" are inverted. And I see that the parameter name has changed. These need to be adjusted IMHO.
There was a problem hiding this comment.
I wonder: maybe should we keep this block and add a .. warning:: Deprecated in 4.2 and add the new parameter with its values...?
There was a problem hiding this comment.
I still don't see how this is related to algorithms IDs.
Anyway, it seems that this PR does not meet your standards and/or expectations from documentation contributions and it would be better if I will refrain from wasting your time by submitting changes.
Sorry for wasting your time, I just wanted to keep things atomic and easier to review.
There was a problem hiding this comment.
@alexbruy Indeed, the suggestions are not related to IDs. I didn't notice the expression "Algorithm ID" in your message. I mainly paid attention to the mentioned PRs for which there is no issue reports in this repo, hence my concern we forget to document the other changes they contain. My mistake. Sorry.
Anyway, I think you could have just replied that you plan to open another PR covering those changes you introduced in the referenced code PRs (e.g., https://github.com/qgis/QGIS/pull/65613/changes#diff-efa53379157d963d693c4f9ba6e90f59afa121bd166b288149eba7b223ab4353R88) or just open that PR, or amend this PR (the commits are already atomic, and the PR wouldn't become that big to handle). There are so many better options than closing the door, don't you think?
DelazJ
added
the
Processing Alg
2 participants
Update IDs of algorithms that were ported to C++.
See qgis/QGIS#64483, qgis/QGIS#65613, qgis/QGIS#65652