Introduce pre-commit as a GitHub automated action#10949
Introduce pre-commit as a GitHub automated action#10949DelazJ wants to merge 3 commits intoqgis:masterfrom
Conversation
|
I would recommend trying to use pre-commit.ci for this repo. We could not do this with QGIS due to its size but I would expect this to work for this one |
|
Thanks @3nids.
I thought this was enough but nothing happens these last weeks. Browsing the code repo I can't see anything obvious (see e.g. https://github.com/qgis/QGIS/pull/61652/changes#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9). So can you please indicate what particular action we need to take? |
|
it needs to be enabled from pre-commit.ci |
|
The main advantage of running it via pre-commit.ci is that you can have autofixing of PRs coming from forks which is not possible when you do it with a workflow. |
|
Merci @3nids |
This is an attempt to instaure the pre-commit checks in Github actions and ensure that we catch errors from any contributors.
The content is highly inspired by the one in code repo and I must confess that I do not understand the whole logic. I just know that it quite works well there so let's try here also. I also picked some formatting from #10856.
@timlinux @3nids May I request your review please ? I don't know if there are additional things to set at the repo level e.g.. Thanks.