Added onPressedWithPosition function to get the position of the menu when opened#61
Open
JI-0 wants to merge 2 commits into
Open
Added onPressedWithPosition function to get the position of the menu when opened#61JI-0 wants to merge 2 commits into
JI-0 wants to merge 2 commits into
Conversation
rasitayaz
reviewed
Sep 4, 2024
rasitayaz
left a comment
rasitayaz
left a comment
Owner
There was a problem hiding this comment.
This feature makes sense, but why didn't you invoke the callback with the rest of them? (onPressed and onPressedWithDevice)
Also, I think we should combine these three callbacks into a single one with an optional 'details' param, which will include both device kind and offset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how desired this is be but can be useful to some in case of building pie menu inside a pie menu or creating reaction animations on top.