Skip to content

media/hevc_d: Fix old-style bit_size handling support#7366

Merged
pelwell merged 2 commits into
raspberrypi:rpi-6.18.yfrom
jc-kynesim:dev/6.18/fix_old_bits_1
May 19, 2026
Merged

media/hevc_d: Fix old-style bit_size handling support#7366
pelwell merged 2 commits into
raspberrypi:rpi-6.18.yfrom
jc-kynesim:dev/6.18/fix_old_bits_1

Conversation

@jc-kynesim
Copy link
Copy Markdown
Contributor

Code to select the old way of setting the bit length of a slice got lost when we moved to 6.18. This fixes it.

Code to select the old way of setting the bit length of a slice got
lost when we moved to 6.18. This fixes it.

Signed-off-by: John Cox <jc@kynesim.co.uk>
@jc-kynesim jc-kynesim force-pushed the dev/6.18/fix_old_bits_1 branch from c95e531 to ecb2f54 Compare May 14, 2026 14:04
@popcornmix
Copy link
Copy Markdown
Collaborator

Ah - I did notice when testing bookworm yesterday that hevc decode failed with size complaints from kernel on 6.18 (but worked on 6.12). I assume this was the cause?

@jc-kynesim
Copy link
Copy Markdown
Contributor Author

Almost certainly

Round old sand format heights to 16 rather than 8 as Pi4 ISP
input requires this (gives EFAULT otherwise). As ISP cannot
take new sand formats do not change them.

Signed-off-by: John Cox <jc@kynesim.co.uk>
@jc-kynesim
Copy link
Copy Markdown
Contributor Author

Added rounding of old sand formats to 16 as Pi4 ISP requires this

@pelwell pelwell merged commit 970a68f into raspberrypi:rpi-6.18.y May 19, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants