Skip to content

fix: config watcher follow symlinks#361

Open
Bubbleioa wants to merge 1 commit intorathole-org:mainfrom
Bubbleioa:fix/follow_symlinks
Open

fix: config watcher follow symlinks#361
Bubbleioa wants to merge 1 commit intorathole-org:mainfrom
Bubbleioa:fix/follow_symlinks

Conversation

@Bubbleioa
Copy link
Copy Markdown

@yujqiao
Copy link
Copy Markdown
Member

yujqiao commented Jun 17, 2025

This one I'm a bit hesitated. If the config is /etc/rathole.toml, this will result in watching every file change under /etc

@yujqiao
Copy link
Copy Markdown
Member

yujqiao commented Jun 17, 2025

That said, I cannot think of another way to fix symlink. readlink -f probably will fail when the file is edited by vim because the inode number could change. Can we watch recursively only when the target file is a symlink? so we can limit the impact

Copy link
Copy Markdown
Member

@yujqiao yujqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think the current approach can be merged given comments above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants