deps: bump franz-go to v1.21.0 for Kafka 4.x GSSAPI compatibility#338
Open
Ceva wants to merge 2 commits into
Open
deps: bump franz-go to v1.21.0 for Kafka 4.x GSSAPI compatibility#338Ceva wants to merge 2 commits into
Ceva wants to merge 2 commits into
Conversation
Update franz-go dependencies to latest versions as gssapi connectivity is broken. Fix was part of Franz go 1.20.7
Bumps github.com/twmb/franz-go from v1.20.6 to v1.21.0 so kminion can authenticate to Kafka 4.x clusters with SASL/GSSAPI (Kerberos). Kafka 4.0 (KIP-896) removed the legacy raw-GSSAPI SASL flow. Every SASL session must now start with a SaslHandshakeRequest (KIP-152), including GSSAPI. franz-go v1.20.6 skipped that handshake for GSSAPI and caused authentication failures with Kafka 4.x. Fixed upstream in franz-go commit e430ea93, included in v1.21.0. Changes: - go.mod: franz-go v1.20.6 → v1.21.0, pkg/kmsg v1.12.0 → v1.13.1 - go.sum: regenerated via go mod tidy - Minor indirect bumps: klauspost/compress, pierrec/lz4/v4, x/crypto, x/net, x/sys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
github.com/twmb/franz-gofrom v1.20.6 to v1.21.0 so kminion can authenticate to Kafka 4.x clusters with SASL/GSSAPI (Kerberos).Why
Kafka 4.0 (KIP-896) removed the legacy raw-GSSAPI SASL flow. Every SASL session must now start with a
SaslHandshakeRequest(KIP-152), including GSSAPI.franz-gov1.20.6 skipped that handshake for GSSAPI and wrote raw tokens straight to the socket, so against a Kafka 4.x broker kminion fails at startup with:Fixed upstream in franz-go
e430ea93("kgo: send SaslHandshake for GSSAPI mechanism"), released in v1.20.7. v1.21.0 picked here as the latest stable.Changes
go.mod:franz-go v1.20.6 → v1.21.0,pkg/kmsg v1.12.0 → v1.13.1go.sum: regenerated viago mod tidygo mod tidy(klauspost/compress,pierrec/lz4/v4,x/crypto,x/net,x/sys)No kminion source code changes.
Reproduce
go get github.com/twmb/franz-go@v1.21.0 go mod tidy go build ./... go test ./...Test plan
Built kminion v2.3.1 with this bump and ran it against a real Kafka 4.1.2 cluster using SASL_SSL + GSSAPI:
Before (v1.20.6):
failed to request metadata: EOFat startup.After (v1.21.0):
go test ./...passes. SASL/PLAIN, SCRAM, OAUTHBEARER, and no-SASL configs are unaffected (they already issued SaslHandshake; this just makes GSSAPI behave the same way).References