Skip to content

164 Verify SSL is ignored when connecting via IP#165

Merged
AnthonyCvn merged 4 commits intomainfrom
164-verifysslfalse-is-ignored-when-connecting-via-ip-tls-altname-validation-still-fails
Apr 13, 2026
Merged

164 Verify SSL is ignored when connecting via IP#165
AnthonyCvn merged 4 commits intomainfrom
164-verifysslfalse-is-ignored-when-connecting-via-ip-tls-altname-validation-still-fails

Conversation

@AnthonyCvn
Copy link
Copy Markdown
Member

@AnthonyCvn AnthonyCvn commented Apr 11, 2026

Closes #164

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

Bug fix

What was changed?

Fix verifySSL=false being silently ignored by moving undici from devDependencies to dependencies

Related issues

No

Does this PR introduce a breaking change?

No

Other information:

@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented Apr 11, 2026

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
30199591 Triggered Generic Private Key 39d92a4 test/VerifySSL.test.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@AnthonyCvn AnthonyCvn requested a review from atimin April 11, 2026 10:54
@AnthonyCvn
Copy link
Copy Markdown
Member Author

@atimin I couldn't reproduce the bug in dev environment but it looks like the problem was that undici was not installed in prod.

@AnthonyCvn AnthonyCvn changed the title 164 verify SSL is ignored when connecting via IP 164 Verify SSL is ignored when connecting via IP Apr 11, 2026
@AnthonyCvn AnthonyCvn enabled auto-merge (squash) April 11, 2026 10:56
@atimin
Copy link
Copy Markdown
Member

atimin commented Apr 11, 2026

@AnthonyCvn try with https://128.140.47.97 , it's orion.

@AnthonyCvn AnthonyCvn merged commit e03298f into main Apr 13, 2026
25 checks passed
@AnthonyCvn AnthonyCvn deleted the 164-verifysslfalse-is-ignored-when-connecting-via-ip-tls-altname-validation-still-fails branch April 13, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

verifySSL=false is ignored when connecting via IP (TLS altname validation still fails)

2 participants