Fix query link creation for new record identity API#167
Merged
Conversation
AnthonyCvn
approved these changes
Apr 15, 2026
tuanhungngyn
approved these changes
Apr 15, 2026
This was referenced Apr 17, 2026
Closed
This was referenced Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What was changed?
record_entryandrecord_timestamp.indexfor compatibility with older API behavior.Bucket.createQueryLinkto resolverecordIndexto an exact record identity (entry+timestamp) using metadata query results before creating the link.recordIndexto ensure it is a non-negative integer.Related issues
reductstore/reductstore#1332
Does this PR introduce a breaking change?
No. Public API remains the same (
recordIndexparameter is still accepted), and payload now supports the new server requirements.Other information:
Validation run:
npm run fmt:checknpm run lintnpm run tscnpx vitest run test/Bucket.test.ts -t "query link" --reporter=verbose(against patched local server)